filetype fixes#1587
Closed
imnotpoz wants to merge 8 commits into
Closed
Conversation
imnotpoz
requested review from
NotAShelf,
Soliprem,
horriblename and
snoweuph
as code owners
17 tasks
imnotpoz
changed the title
https://github.com/neovim/neovim/blob/master/runtime/syntax/asmh8300.vim `:checkhealth` output: ``` -⚠️ WARNING Unknown filetype 'asm8300' (Hint: filename extension != filetype). ```
`:checkhealth` output: ``` -⚠️ WARNING Unknown filetype 'ash' (Hint: filename extension != filetype). -⚠️ WARNING Unknown filetype 'dash' (Hint: filename extension != filetype). ```
`:checkhealth` output: ``` -⚠️ WARNING Unknown filetype 'vert' (Hint: filename extension != filetype). -⚠️ WARNING Unknown filetype 'tesc' (Hint: filename extension != filetype). -⚠️ WARNING Unknown filetype 'tese' (Hint: filename extension != filetype). -⚠️ WARNING Unknown filetype 'frag' (Hint: filename extension != filetype). -⚠️ WARNING Unknown filetype 'geom' (Hint: filename extension != filetype). -⚠️ WARNING Unknown filetype 'comp' (Hint: filename extension != filetype). ```
`:checkhealth` output: ``` -⚠️ WARNING Unknown filetype 'gotmpl' (Hint: filename extension != filetype). ```
`:checkhealth` output: ``` -⚠️ WARNING Unknown filetype 'mdx' (Hint: filename extension != filetype). ```
`:checkhealth` output: ``` -⚠️ WARNING Unknown filetype 'menhir' (Hint: filename extension != filetype). -⚠️ WARNING Unknown filetype 'ocamlinterface' (Hint: filename extension != filetype). -⚠️ WARNING Unknown filetype 'ocamllex' (Hint: filename extension != filetype). -⚠️ WARNING Unknown filetype 'reason' (Hint: filename extension != filetype). ```
`:checkhealth` output: ``` -⚠️ WARNING Unknown filetype 'shtml' (Hint: filename extension != filetype). -⚠️ WARNING Unknown filetype 'htm' (Hint: filename extension != filetype). ```
`:checkhealth` output: ``` -⚠️ WARNING Unknown filetype 'typescript.tsx' (Hint: filename extension != filetype). -⚠️ WARNING Unknown filetype 'javascript.jsx' (Hint: filename extension != filetype). ```
snoweuph
reviewed
May 13, 2026
| presets = genAttrs cfg.lsp.servers (_: {enable = true;}); | ||
| servers = genAttrs cfg.lsp.servers (_: { | ||
| filetypes = ["asm" "nasm" "masm" "vmasm" "fasm" "tasm" "tiasm" "asm68k" "asm8300"]; | ||
| filetypes = ["asm" "nasm" "masm" "vmasm" "fasm" "tasm" "tiasm" "asm68k" "asmh8300"]; |
Collaborator
There was a problem hiding this comment.
will already be fixed in !1583 which changes the asm module a bit
snoweuph
reviewed
May 13, 2026
| presets = genAttrs cfg.lsp.servers (_: {enable = true;}); | ||
| servers = genAttrs cfg.lsp.servers (_: { | ||
| filetypes = ["go" "gomod" "gosum" "gowork" "gotmpl"]; | ||
| filetypes = ["go" "gomod" "gosum" "gowork"]; |
Collaborator
There was a problem hiding this comment.
don't remove gotmpl, instead we need to introduce this filetype or LSPs and Tree-sitter will in fact behave wrongly.
In my NVF config I have
to map, but to actually introduce this filetype we need #1365 , cause raf doesn't want these auto commands in NVF rn.
snoweuph
reviewed
May 13, 2026
| presets = genAttrs cfg.lsp.servers (_: {enable = true;}); | ||
| servers = genAttrs cfg.lsp.servers (_: { | ||
| filetypes = ["markdown" "mdx"]; | ||
| filetypes = ["markdown"]; |
Collaborator
There was a problem hiding this comment.
I think there was some other issue related to this.
snoweuph
reviewed
May 13, 2026
| "typescript" | ||
| # TODO: move to a React module | ||
| "typescriptreact" | ||
| "typescript.tsx" |
Collaborator
There was a problem hiding this comment.
Not a react dev, but I think this will break some LSPs,
We should really only comment out and wait for #1365 so we can introduce extra types where actual required and remove things that are nonsense.
snoweuph
reviewed
May 13, 2026
| presets = genAttrs cfg.lsp.servers (_: {enable = true;}); | ||
| servers = genAttrs cfg.lsp.servers (_: { | ||
| filetypes = ["glsl" "vert" "tesc" "tese" "frag" "geom" "comp"]; | ||
| filetypes = ["glsl"]; |
Collaborator
There was a problem hiding this comment.
Could you only comment them out with a TODO, to introduce mappings for these extensions as soon as #1365 lands?
Contributor
Author
|
closing as I opened the PR having no idea about how filetypes work :PPP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit messages contain some links and
:checkhealthoutputall of these gave me warnings in
:checkhealth, all of which are gone with this PR - no more warnings undervim.lspSanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.