Vanilla Admonitions improvements#3280
Merged
Merged
Conversation
- increase title's font size - render left border with relevant color for each type of admonition - render icon
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
anegg0
requested review from
Jason-W123 and
fionnachan
and removed request for
Jason-W123 and
pete-vielhaber
fionnachan
approved these changes
May 18, 2026
Member
fionnachan
left a comment
fionnachan
left a comment
There was a problem hiding this comment.
LGTM but one thing to note (already live on production) is that the some code became italic on dark mode
but that is an issue with the code block in general and not this VanillaAdmonition component
Contributor
Author
Thank you for pointing this out, and for the review, @fionnachan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add improved styles for vanilla admonitions:
Document type