Updated parameter names to be more consistent

Some of the objects to work against were named `target` when they should have been `source` (e.g., when calling `GetPropertyValue()`). The member names were inconsistently named either `name` or `memberName`; updated these to use `memberName`, `propertyName`, or `methodName`. This makes the parameter names more intuitive.

Author: JeremyCaney

OnTopic/Internal/Reflection/TypeAccessor.cs

@@ -125,11 +125,11 @@ internal IEnumerable<T> GetMembers<T>() where T : MemberInfo
     | GET MEMBER
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Retrieves a property or method supported by the <see cref="TypeAccessor"/> by <paramref name="name"/>.
+    ///   Retrieves a property or method supported by the <see cref="TypeAccessor"/> by <paramref name="memberName"/>.
     /// </summary>
-    /// <param name="name">The name of the <see cref="MemberAccessor"/>, derived from <see cref="MemberInfo.Name"/>.</param>
+    /// <param name="memberName">The name of the member to retrieve, derived from <see cref="MemberAccessor.Name"/>.</param>
     /// <returns>A <see cref="MemberAccessor"/> instance for getting or setting values on a given member.</returns>
-    internal MemberAccessor? GetMember(string name) => _members.GetValueOrDefault(name);
+    internal MemberAccessor? GetMember(string memberName) => _members.GetValueOrDefault(memberName);
 
     /*==========================================================================================================================
     | METHOD: GET PRIMARY CONSTRUCTOR
@@ -145,11 +145,12 @@ internal ConstructorInfo GetPrimaryConstructor() =>
     | HAS GETTER?
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Determines if a <see cref="MemberAccessor"/> with a getter exists for a member with the given <paramref name="name"/>.
+    ///   Determines if a <see cref="MemberAccessor"/> with a getter exists for a member with the given <paramref name="
+    ///   memberName"/>.
     /// </summary>
-    /// <param name="name">The name of the <see cref="MemberAccessor"/>, derived from <see cref="MemberInfo.Name"/>.</param>
+    /// <param name="memberName">The name of the member to assess, derived from <see cref="MemberAccessor.Name"/>.</param>
     /// <returns>True if a gettable member exists; otherwise false.</returns>
-    internal bool HasGetter(string name) => GetMember(name)?.CanRead ?? false;
+    internal bool HasGetter(string memberName) => GetMember(memberName)?.CanRead ?? false;
 
     /*==========================================================================================================================
     | METHOD: HAS GETTABLE PROPERTY
@@ -160,11 +161,11 @@ internal ConstructorInfo GetPrimaryConstructor() =>
     /// <remarks>
     ///   Will return false if the property is not available.
     /// </remarks>
-    /// <param name="name">The name of the property to assess.</param>
+    /// <param name="propertyName">The name of the property to assess, derived from <see cref="MemberAccessor.Name"/>.</param>
     /// <param name="targetType">Optional, the <see cref="Type"/> expected.</param>
     /// <param name="attributeFlag">Optional, the <see cref="Attribute"/> expected on the property.</param>
-    internal bool HasGettableProperty(string name, Type? targetType = null, Type? attributeFlag = null) {
-      var property = GetMember(name);
+    internal bool HasGettableProperty(string propertyName, Type? targetType = null, Type? attributeFlag = null) {
+      var property = GetMember(propertyName);
       return (
         property is not null and { CanRead: true, MemberType: MemberTypes.Property } &&
         property.IsSettable(targetType, true) &&
@@ -174,8 +175,8 @@ internal bool HasGettableProperty(string name, Type? targetType = null, Type? at
 
     /// <inheritdoc cref="HasGettableProperty(string, Type?, Type?)"/>
     /// <typeparam name="T">The <see cref="Attribute"/> expected on the property.</typeparam>
-    internal bool HasGettableProperty<T>(string name, Type? targetType = null) where T : Attribute
-      => HasGettableProperty(name, targetType, typeof(T));
+    internal bool HasGettableProperty<T>(string propertyName, Type? targetType = null) where T : Attribute
+      => HasGettableProperty(propertyName, targetType, typeof(T));
 
     /*==========================================================================================================================
     | METHOD: HAS GETTABLE METHOD
@@ -187,11 +188,11 @@ internal bool HasGettableProperty<T>(string name, Type? targetType = null) where
     ///   Will return false if the method is not available. Methods are only considered gettable if they have no parameters and
     ///   their return value is a settable type.
     /// </remarks>
-    /// <param name="name">The name of the method to assess.</param>
+    /// <param name="methodName">The name of the method to assess, derived from <see cref="MemberAccessor.Name"/>.</param>
     /// <param name="targetType">Optional, the <see cref="Type"/> expected.</param>
     /// <param name="attributeFlag">Optional, the <see cref="Attribute"/> expected on the property.</param>
-    internal bool HasGettableMethod(string name, Type? targetType = null, Type? attributeFlag = null) {
-      var method = GetMember(name);
+    internal bool HasGettableMethod(string methodName, Type? targetType = null, Type? attributeFlag = null) {
+      var method = GetMember(methodName);
       return (
         method is not null and { CanRead: true, MemberType: MemberTypes.Method } &&
         method.IsSettable(targetType, true) &&
@@ -212,7 +213,7 @@ internal bool HasGettableMethod<T>(string name, Type? targetType = null) where T
     ///   object.
     /// </summary>
     /// <param name="source">The <see cref="Object"/> instance from which the value should be retrieved.</param>
-    /// <param name="memberName">The name of the method or property from which the value should be retrieved.</param>
+    /// <param name="memberName">The name of the member to retrieve, derived from <see cref="MemberAccessor.Name"/>.</param>
     /// <returns>The value returned from the member.</returns>
     internal object? GetValue(object source, string memberName) {
 
@@ -245,29 +246,30 @@ internal bool HasGettableMethod<T>(string name, Type? targetType = null) where T
     ///   Uses reflection to call a property, assuming that it is a) readable, and b) of type <see cref="String"/>,
     ///   <see cref="Int32"/>, or <see cref="Boolean"/>.
     /// </summary>
-    /// <param name="target">The object instance on which the property is defined.</param>
-    /// <param name="name">The name of the property to assess.</param>
-    internal object? GetPropertyValue(object target, string name) => GetValue(target, name);
+    /// <param name="source">The object instance on which the property is defined.</param>
+    /// <param name="propertyName">The name of the property to retrieve, derived from <see cref="MemberAccessor.Name"/>.</param>
+    internal object? GetPropertyValue(object source, string propertyName) => GetValue(source, propertyName);
 
     /*==========================================================================================================================
     | METHOD: GET METHOD VALUE
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Uses reflection to call a method, assuming that it has no parameters.
     /// </summary>
-    /// <param name="target">The object instance on which the method is defined.</param>
-    /// <param name="name">The name of the method to assess.</param>
-    internal object? GetMethodValue(object target, string name) => GetValue(target, name);
+    /// <param name="source">The object instance on which the method is defined.</param>
+    /// <param name="methodName">The name of the method to retrieve, derived from <see cref="MemberAccessor.Name"/>.</param>
+    internal object? GetMethodValue(object source, string methodName) => GetValue(source, methodName);
 
     /*==========================================================================================================================
     | HAS SETTER?
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Determines if a <see cref="MemberAccessor"/> with a setter exists for a member with the given <paramref name="name"/>.
+    ///   Determines if a <see cref="MemberAccessor"/> with a setter exists for a member with the given <paramref name="
+    ///   memberName"/>.
     /// </summary>
-    /// <param name="name">The name of the <see cref="MemberAccessor"/>, derived from <see cref="MemberInfo.Name"/>.</param>
+    /// <param name="memberName">The name of the member to assess, derived from <see cref="MemberAccessor.Name"/>.</param>
     /// <returns>True if a settable member exists; otherwise false.</returns>
-    internal bool HasSetter(string name) => GetMember(name)?.CanWrite ?? false;
+    internal bool HasSetter(string memberName) => GetMember(memberName)?.CanWrite ?? false;
 
     /*==========================================================================================================================
     | METHOD: HAS SETTABLE PROPERTY
@@ -278,11 +280,11 @@ internal bool HasGettableMethod<T>(string name, Type? targetType = null) where T
     /// <remarks>
     ///   Will return false if the property is not available.
     /// </remarks>
-    /// <param name="name">The name of the property to assess.</param>
+    /// <param name="propertyName">The name of the property to assess, derived from <see cref="MemberAccessor.Name"/>.</param>
     /// <param name="targetType">Optional, the <see cref="Type"/> expected.</param>
     /// <param name="attributeFlag">Optional, the <see cref="Attribute"/> expected on the property.</param>
-    internal bool HasSettableProperty(string name, Type? targetType = null, Type? attributeFlag = null) {
-      var property = GetMember(name);
+    internal bool HasSettableProperty(string propertyName, Type? targetType = null, Type? attributeFlag = null) {
+      var property = GetMember(propertyName);
       return (
         property is not null and { CanWrite: true, MemberType: MemberTypes.Property } &&
         property.IsSettable(targetType, true) &&
@@ -292,8 +294,8 @@ internal bool HasSettableProperty(string name, Type? targetType = null, Type? at
 
     /// <inheritdoc cref="HasSettableProperty(string, Type?, Type?)"/>
     /// <typeparam name="T">The <see cref="Attribute"/> expected on the property.</typeparam>
-    internal bool HasSettableProperty<T>(string name, Type? targetType = null) where T : Attribute
-      => HasSettableProperty(name, targetType, typeof(T));
+    internal bool HasSettableProperty<T>(string propertyName, Type? targetType = null) where T : Attribute
+      => HasSettableProperty(propertyName, targetType, typeof(T));
 
     /*==========================================================================================================================
     | METHOD: HAS SETTABLE METHOD
@@ -306,11 +308,11 @@ internal bool HasSettableProperty<T>(string name, Type? targetType = null) where
     ///   a settable type. Be aware that this will return <c>false</c> if the method has additional parameters, even if those
     ///   additional parameters are optional.
     /// </remarks>
-    /// <param name="name">The name of the method to assess.</param>
+    /// <param name="methodName">The name of the method to assess, derived from <see cref="MemberAccessor.Name"/>.</param>
     /// <param name="targetType">Optional, the <see cref="Type"/> expected.</param>
     /// <param name="attributeFlag">Optional, the <see cref="Attribute"/> expected on the property.</param>
-    internal bool HasSettableMethod(string name, Type? targetType = null, Type? attributeFlag = null) {
-      var method = GetMember(name);
+    internal bool HasSettableMethod(string methodName, Type? targetType = null, Type? attributeFlag = null) {
+      var method = GetMember(methodName);
       return (
         method is not null and { CanWrite: true, MemberType: MemberTypes.Method } &&
         method.IsSettable(targetType, true) &&
@@ -320,8 +322,8 @@ internal bool HasSettableMethod(string name, Type? targetType = null, Type? attr
 
     /// <inheritdoc cref="HasSettableMethod(String, Type?, Type?)"/>
     /// <typeparam name="T">The <see cref="Attribute"/> expected on the property.</typeparam>
-    internal bool HasSettableMethod<T>(string name, Type? targetType = null) where T : Attribute
-      => HasSettableMethod(name, targetType, typeof(T));
+    internal bool HasSettableMethod<T>(string methodName, Type? targetType = null) where T : Attribute
+      => HasSettableMethod(methodName, targetType, typeof(T));
 
     /*==========================================================================================================================
     | SET VALUE
@@ -330,7 +332,7 @@ internal bool HasSettableMethod<T>(string name, Type? targetType = null) where T
     ///   Sets the value of a member named <paramref name="memberName"/> on the supplied <paramref name="target"/> object.
     /// </summary>
     /// <param name="target">The <see cref="Object"/> instance on which the value should be set.</param>
-    /// <param name="memberName">The name of the method or property on which the value should be set.</param>
+    /// <param name="memberName">The name of the member to set, derived from <see cref="MemberAccessor.Name"/>.</param>
     /// <param name="value">The <see cref="Object"/> value to set the member to.</param>
     /// <param name="allowConversion">
     ///   Determines whether a fallback to <see cref="AttributeValueConverter.Convert(String?, Type)"/> is permitted.
@@ -365,13 +367,13 @@ internal void SetValue(object target, string memberName, object? value, bool all
     ///   Int32"/>, or <see cref="Boolean"/>, or is otherwise compatible with the <paramref name="value"/> type.
     /// </summary>
     /// <param name="target">The object on which the property is defined.</param>
-    /// <param name="name">The name of the property to assess.</param>
+    /// <param name="propertyName">The name of the property to set, derived from <see cref="MemberAccessor.Name"/>.</param>
     /// <param name="value">The value to set on the property.</param>
     /// <param name="allowConversion">
     ///   Determines whether a fallback to <see cref="AttributeValueConverter.Convert(String?, Type)"/> is permitted.
     /// </param>
-    internal void SetPropertyValue(object target, string name, object? value, bool allowConversion = false)
-      => SetValue(target, name, value, allowConversion);
+    internal void SetPropertyValue(object target, string propertyName, object? value, bool allowConversion = false)
+      => SetValue(target, propertyName, value, allowConversion);
 
     /*==========================================================================================================================
     | METHOD: SET METHOD VALUE
@@ -385,13 +387,13 @@ internal void SetPropertyValue(object target, string name, object? value, bool a
     ///   are present it will return <c>false</c>, even if those additional parameters are optional.
     /// </remarks>
     /// <param name="target">The object instance on which the method is defined.</param>
-    /// <param name="name">The name of the method to assess.</param>
+    /// <param name="methodName">The name of the method to set, derived from <see cref="MemberAccessor.Name"/>.</param>
     /// <param name="value">The value to set the method to.</param>
     /// <param name="allowConversion">
     ///   Determines whether a fallback to <see cref="AttributeValueConverter.Convert(String?, Type)"/> is permitted.
     /// </param>
-    internal void SetMethodValue(object target, string name, object? value, bool allowConversion = false)
-      => SetValue(target, name, value, allowConversion);
+    internal void SetMethodValue(object target, string methodName, object? value, bool allowConversion = false)
+      => SetValue(target, methodName, value, allowConversion);
 
   } //Class
-} //Namespace
+} //Namespace