Centralized IsSettable() on MemberAccessor

This simply allows `IsSettable()` to be called directly, if need be, off of the `MemberAccessor` without relying on a reference to the `TypeAccessor`. This isn't currently needed, but it doesn't really add any code or complexity.

While I was at it, I improved the `IsSettable()` logic to be more consistent with the actual `GetValue()` and `SetValue()` logic. For instance, it now checks both source and target type convertibility, and optionally allows convertibility to be toggled. We're not exposing `allowConversion` on the hassable methods (e.g., `HasGetterProperty()`), so these are hard-coded to `true` in those calls.

Author: JeremyCaney

OnTopic/Internal/Reflection/MemberAccessor.cs

@@ -125,6 +125,28 @@ internal MemberAccessor(MemberInfo memberInfo) {
     /// </remarks>
     internal bool CanWrite { get; private set; }
 
+    /*==========================================================================================================================
+    | METHOD: IS SETTABLE?
+    \-------------------------------------------------------------------------------------------------------------------------*/
+    /// <summary>
+    ///   Determines whether the current member is settable, either assuming the list of <see cref="AttributeValueConverter"/>,
+    ///   or provided a specific <paramref name="sourceType"/>.
+    /// </summary>
+    /// <param name="sourceType">The <see cref="System.Type"/> to evaluate against <see cref="Type"/>.</param>
+    /// <param name="allowConversion">
+    ///   Determines whether a fallback to <see cref="AttributeValueConverter.Convert(String?, Type)"/> is permitted.
+    /// </param>
+    internal bool IsSettable(Type? sourceType = null, bool allowConversion = false) {
+      if (sourceType is not null && (sourceType == Type || Type.IsAssignableFrom(sourceType))) {
+        return true;
+      }
+      if (allowConversion) {
+        var isTargetCompatible  = AttributeValueConverter.IsConvertible(Type);
+        var isSourceCompatible  = sourceType is null || AttributeValueConverter.IsConvertible(sourceType);
+        return isTargetCompatible && isSourceCompatible;
+      }
+      return false;
+    }
 
     /*==========================================================================================================================
     | GET VALUE

OnTopic/Internal/Reflection/TypeAccessor.cs

@@ -167,7 +167,7 @@ internal bool HasGettableProperty(string name, Type? targetType = null, Type? at
       var property = GetMember(name);
       return (
         property is not null and { CanRead: true, MemberType: MemberTypes.Property } &&
-        IsSettableType(property.Type, targetType) &&
+        property.IsSettable(targetType, true) &&
         (attributeFlag is null || Attribute.IsDefined(property.MemberInfo, attributeFlag))
       );
     }
@@ -194,7 +194,7 @@ internal bool HasGettableMethod(string name, Type? targetType = null, Type? attr
       var method = GetMember(name);
       return (
         method is not null and { CanRead: true, MemberType: MemberTypes.Method } &&
-        IsSettableType(method.Type, targetType) &&
+        method.IsSettable(targetType, true) &&
         (attributeFlag is null || Attribute.IsDefined(method.MemberInfo, attributeFlag))
       );
     }
@@ -285,7 +285,7 @@ internal bool HasSettableProperty(string name, Type? targetType = null, Type? at
       var property = GetMember(name);
       return (
         property is not null and { CanWrite: true, MemberType: MemberTypes.Property } &&
-        IsSettableType(property.Type, targetType) &&
+        property.IsSettable(targetType, true) &&
         (attributeFlag is null || Attribute.IsDefined(property.MemberInfo as PropertyInfo, attributeFlag))
       );
     }
@@ -313,7 +313,7 @@ internal bool HasSettableMethod(string name, Type? targetType = null, Type? attr
       var method = GetMember(name);
       return (
         method is not null and { CanWrite: true, MemberType: MemberTypes.Method } &&
-        IsSettableType(method.Type, targetType) &&
+        method.IsSettable(targetType, true) &&
         (attributeFlag is null || Attribute.IsDefined(method.MemberInfo, attributeFlag))
       );
     }
@@ -393,21 +393,5 @@ internal void SetPropertyValue(object target, string name, object? value, bool a
     internal void SetMethodValue(object target, string name, object? value, bool allowConversion = false)
       => SetValue(target, name, value, allowConversion);
 
-    /*==========================================================================================================================
-    | METHOD: IS SETTABLE TYPE?
-    \-------------------------------------------------------------------------------------------------------------------------*/
-    /// <summary>
-    ///   Determines whether a given type is settable, either assuming the list of <see cref="AttributeValueConverter"/>, or
-    ///   provided a specific <paramref name="targetType"/>.
-    /// </summary>
-    private static bool IsSettableType(Type sourceType, Type? targetType = null) {
-
-      if (targetType is not null) {
-        return sourceType.IsAssignableFrom(targetType);
-      }
-      return AttributeValueConverter.IsConvertible(sourceType);
-
-    }
-
   } //Class
 } //Namespace