Skip to content

Specify Gradle version for linux workflow to ensure compatibility with JDK 11#21720

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
Mattias-Sehlstedt:linux-github-action
Aug 9, 2025
Merged

Specify Gradle version for linux workflow to ensure compatibility with JDK 11#21720
wing328 merged 1 commit intoOpenAPITools:masterfrom
Mattias-Sehlstedt:linux-github-action

Conversation

@Mattias-Sehlstedt
Copy link
Copy Markdown
Contributor

@Mattias-Sehlstedt Mattias-Sehlstedt commented Aug 9, 2025

The current linux workflow does not work for two reasons:

I have adjusted for these errors by changing the flag and setting the Gradle version to the lastest supporting JDK 11.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Mattias-Sehlstedt Mattias-Sehlstedt marked this pull request as ready for review August 9, 2025 11:12
@wing328 wing328 merged commit 6ff9e67 into OpenAPITools:master Aug 9, 2025
11 checks passed
@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 9, 2025

thanks for the PR which has been merged

have a nice weekend

@wing328 wing328 added this to the 7.15.0 milestone Aug 9, 2025
@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 14, 2025

@Mattias-Sehlstedt looks like linux workflow is completely skipped as line 72 has issues: https://github.com/OpenAPITools/openapi-generator/actions/runs/16955828402

can you please take a look when you've time?

@wing328 wing328 mentioned this pull request Aug 14, 2025
6 tasks
@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 14, 2025

no worry. fixed via #21743

@Mattias-Sehlstedt
Copy link
Copy Markdown
Contributor Author

Thanks for the fix 👍

@davidgamero davidgamero mentioned this pull request Aug 16, 2025
6 tasks
@Mattias-Sehlstedt Mattias-Sehlstedt deleted the linux-github-action branch August 16, 2025 13:01
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants