Fix so that the normalizer retains the read/write only attribute#21737
Conversation
what do you mean by that? do you mean we should also handle other meta data in addition to readonly, writeonly? |
I was just wondering, without putting too much thought into it, whether there are additional attributes that might be relevant to keep when doing the normalization. |
|
Converted to draft since I see now that this not really represent the issue reported, will look further into it. |
8e932d1 to
81243de
Compare
|
@Mattias-Sehlstedt @wing328 |
|
Since there was no discussion regarding my speculation on whether it was relevant to do But if you have further issues with metadata propagation, I believe it would be best to raise an issue for that and exemplify what data that is "lost". |
Fixes #21732.
I have added so that it keeps ReadOnly and WriteOnly, but it might be that one should even run copyMetadata?
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)