Skip to content

fix: do not add dependency on urllib3 if not required#22441

Closed
saschakr wants to merge 1 commit intoOpenAPITools:masterfrom
saschakr:fix-issue-22436
Closed

fix: do not add dependency on urllib3 if not required#22441
saschakr wants to merge 1 commit intoOpenAPITools:masterfrom
saschakr:fix-issue-22436

Conversation

@saschakr
Copy link
Copy Markdown
Contributor

@saschakr saschakr commented Nov 26, 2025

fix issue: #22436

PR checklist

  • [ x] Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 26, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 26, 2025

please follow step 3 to update the samples

@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 27, 2025

filed #22453 with updated samples

let's see how that goes

@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 27, 2025

tests failed with updated samples: https://github.com/OpenAPITools/openapi-generator/actions/runs/19727703716/job/56522154078?pr=22453

can you please also update the tests (aiohttp) to remove dependencies on urllib3 ?

update: done in that PR (#22453)

@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 27, 2025

merged via #22453 (listing you as co-author)

closing this one

@wing328 wing328 closed this Nov 27, 2025
@saschakr
Copy link
Copy Markdown
Contributor Author

@wing328 thank you so much ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants