Fixed incompatibility with for the OpenMDAO:3.39.0#102
Closed
arushkumarsingh wants to merge 1 commit into
Closed
Conversation
Member
|
I don't think we want to remove the promotions because the intent is for the cycle params to be connected to the same source so that the values can be changed in unison. I am working on something to fix this. |
Member
|
Superceded by #103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solution for issue #100
Currently, the cycle variables are set up using the function pyc_add_cycle_param, which calls the configure() function in the mp_cycle.py. The configure function is promoting the variables to the cycle. The openmdao: 3.39.0 version is causing the incompatibility here, as the variables need to be accessed as component.var instead of point.component.var. So, instead of promoting the variables, we can set the variables for each design and off-design point.
This issue can be solved in two ways.
Going and updating all the output codes to print burner.dpqp instead of point.burner.dpqp. Similarly, for all the variables which are set using self.pyc_add_cycle_param
Changing the pyc_add_cycle_param() function pipeline, which can be solved by changing the function def configure(self) in the mp_cycle. (This pull request)
P.s. This is the PR with the signed commit
Related Issues
Backwards incompatibilities
None
New Dependencies
None