Skip to content

Fixed incompatibility with for the OpenMDAO:3.39.0#102

Closed
arushkumarsingh wants to merge 1 commit into
OpenMDAO:masterfrom
arushkumarsingh:issue100
Closed

Fixed incompatibility with for the OpenMDAO:3.39.0#102
arushkumarsingh wants to merge 1 commit into
OpenMDAO:masterfrom
arushkumarsingh:issue100

Conversation

@arushkumarsingh
Copy link
Copy Markdown
Contributor

Summary

Solution for issue #100

Currently, the cycle variables are set up using the function pyc_add_cycle_param, which calls the configure() function in the mp_cycle.py. The configure function is promoting the variables to the cycle. The openmdao: 3.39.0 version is causing the incompatibility here, as the variables need to be accessed as component.var instead of point.component.var. So, instead of promoting the variables, we can set the variables for each design and off-design point.

This issue can be solved in two ways.

Going and updating all the output codes to print burner.dpqp instead of point.burner.dpqp. Similarly, for all the variables which are set using self.pyc_add_cycle_param
Changing the pyc_add_cycle_param() function pipeline, which can be solved by changing the function def configure(self) in the mp_cycle. (This pull request)

P.s. This is the PR with the signed commit

Related Issues

Backwards incompatibilities

None

New Dependencies

None

@Kenneth-T-Moore
Copy link
Copy Markdown
Member

I don't think we want to remove the promotions because the intent is for the cycle params to be connected to the same source so that the values can be changed in unison. I am working on something to fix this.

@Kenneth-T-Moore
Copy link
Copy Markdown
Member

Superceded by #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compatibility with OpenMDAO 3.39.0

2 participants