Port PoB 2 Oauth API by vaisest · Pull Request #9812 · PathOfBuildingCommunity/PathOfBuilding

vaisest · 2026-04-24T08:30:47Z

I can't find relevant issues, but this primarily fixes annoying issues with POESESSID expiring all the time. For imports, this also automatically adds bandit and pantheon choices, as the OAuth API contains info for them.

Probably enables #5418 via the oauth API, though the current scope does not include account:stashes.

Description of the problem being solved:

Steps taken to verify a working solution:

Quite a lot of manual testing using my own account. That means, only PC and no console/asian realms tested. I did test multiple leagues, but I don't have many legacy things on my account so who knows what I've missed.
There are also some previous tests using the import functionality. Although they do focus on gem import details, and more should probably be added.

What this PR still needs

I think this is getting quite close to done, but seeing as it is making a lot of changes to a vital part of the UI, it probably needs a lot more testing. I'm not sure I got all of the differences between the PoE site character data and API data. There might be some legacy things that I don't know about, and I'm not sure about other quirks (like for example the league field in the API is nullable: why?). I also can't test other realm imports since I've only ever played on PC.

The account name import doesn't seem to report 404s at all. I'm not sure if this ever worked, because the website just results in a 403 for me.

Questions about the UX/UI design were also raised on Discord.

Link to a build that showcases this PR:

N/A

Before screenshot:

After screenshot:

vaisest · 2026-04-24T13:02:21Z

 					if node.oidx == data.orbitIndex and not data.isMastery then
 						for _, extendedId in ipairs(importedGroups[proxyGroup].nodes) do
-							if id == tonumber(extendedId) and inExtendedHashes(id) then
+							if id == extendedId and inExtendedHashes(tonumber(id)) then


Hopefully this doesn't break anything else. The cluster data is exactly the same as previously, but this seemed to be comparing strings to numbers. Type hints / checking would be really useful here, because I'm not sure what is correct here

vaisest · 2026-04-25T13:05:27Z

The import changes will probably end up being rather broad as it seems really difficult to try to combine the old and new UI. Currently trying to make the oauth version simpler and then I can add the account search back in.

I think the oauth version could just be two menus for either logged in or not, but atm rate limiting is an issue (2 per 10s or 5 per 300s) is an issue so it probably needs to have a manual refresh button for looking up realm characters

$Path{space}of{space}Building_2026-04-25_15-59-45$

vaisest · 2026-04-26T14:49:58Z

The changes seem to break mcagnion's tests, even though the functionality seems to work. I'm not really seeing why that is. Otherwise everything seems to work so far

mcagnion · 2026-04-26T15:17:10Z

If ImportItemsAndSkills now reads charData.level directly :

 local function buildImportPayload(items)
     return {
-        character = { level = DEFAULT_CHARACTER_LEVEL },
+        level = DEFAULT_CHARACTER_LEVEL,
         equipment = items,
     }
 end

vaisest · 2026-04-26T15:46:18Z

If ImportItemsAndSkills now reads charData.level directly :

 local function buildImportPayload(items)
     return {
-        character = { level = DEFAULT_CHARACTER_LEVEL },
+        level = DEFAULT_CHARACTER_LEVEL,
         equipment = items,
     }
 end

Thanks, that was indeed it. Seems very obvious in hindsight lol

…equery

Nightblade · 2026-05-05T08:29:51Z

+                self.lastRealm = node.attrib.lastRealm
+                self.lastLeague = node.attrib.lastLeague
+                self.lastToken = node.attrib.lastToken


Space indentation.

Nightblade · 2026-05-05T08:30:03Z

+    local accounts = { elem = "Accounts", attrib = { lastAccountName = self.lastAccountName, lastRealm = self.lastRealm, lastLeague = self.lastLeague, lastToken = self.lastToken, lastRefreshToken = self.lastRefreshToken, tokenExpiry = tostring(self.tokenExpiry) } }
+    for accountName, account in pairs(self.gameAccounts) do


Space indentation.

vaisest · 2026-05-08T14:29:20Z

+describe("TestImport", function()
+	local dkjson = require "dkjson"
+
+	local sampleJson, err = io.open("../spec/System/SampleCharacter.json", "r")


Hopefully testing like this is ok? This is probably not very portable across newer leagues, but I couldn't think of anything more practical for testing passive tree imports. This is mostly just what the GGG API returned for my current league lvl 99 kboc hierophant

vaisest · 2026-05-09T15:45:29Z

I've noticed that there's something in the compare tab that breaks the trade tool. To reproduce:

Open a build
Go to the compare tab and import another build
Go to the trader tool and try to search for an item. It will generate mod weights, but will not fill in a search url. This causes it to get stuck.

This isn't caused by this PR either as it's also present on the beta version. I tried to fix it, but couldn't figure out what was causing it. My assumption is it could be related to how the compare tab wraps the items tab?

Edit: possibly caused by compare tab overwriting the onframe function when it wraps the tab?

vaisest added 4 commits April 24, 2026 11:29

Port PoB 2 trader Oauth API

26bc287

passive import working

ec61c3b

bloodline and gem+item import

0927682

fix cluster

5c1ad21

vaisest commented Apr 24, 2026

View reviewed changes

very wip import refactor

67c8891

vaisest added 2 commits April 26, 2026 16:56

make import have options for both oauth and website import

6649818

slightly fix tests

555732c

Fix test

088b213

change headless wrapper example (untested otherwise)

b5dc5ba

vaisest force-pushed the oauth-support branch from 1331434 to b5dc5ba Compare April 27, 2026 09:53

Fix spaces in ImportTab.lua

368e841

Nightblade suggested changes Apr 27, 2026

View reviewed changes

Comment thread src/Classes/PoEAPI.lua Outdated

Comment thread src/LaunchServer.lua Outdated

vaisest added 9 commits April 27, 2026 13:12

Fix more indentations and remove extra function

d0624f7

Fix LaunchServer.lua indents

64c6723

Add comparison dropdown option back

39e5e5c

Prevent crash on semi-invalid JSON

b3f50f2

Change 403 error message

9616d35

Remove error code on login and fix hanging item slot controls in trad…

f0aba17

…equery

prefer last league, realm, and character

a2ed48d

Remove extra realms from oauth api

420a2e1

Fix rate limit in import tab

3981952

vaisest marked this pull request as ready for review May 4, 2026 16:34

Nightblade reviewed May 5, 2026

View reviewed changes

whitespace...

4baa6aa

vaisest added 2 commits May 6, 2026 17:54

fix site import crash

e8d84c8

fix import masteries and overrides not working due to improper typing

72a198e

vaisest force-pushed the oauth-support branch from f5dd48a to bde11fd Compare May 8, 2026 13:31

Add tests for importing passive trees and fix control issues

78a929a

vaisest force-pushed the oauth-support branch from bde11fd to 78a929a Compare May 8, 2026 14:10

vaisest commented May 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port PoB 2 Oauth API#9812

Port PoB 2 Oauth API#9812
vaisest wants to merge 23 commits intoPathOfBuildingCommunity:devfrom
vaisest:oauth-support

vaisest commented Apr 24, 2026 •

edited

Loading

Uh oh!

vaisest Apr 24, 2026

Uh oh!

vaisest commented Apr 25, 2026

Uh oh!

vaisest commented Apr 26, 2026

Uh oh!

mcagnion commented Apr 26, 2026

Uh oh!

vaisest commented Apr 26, 2026

Uh oh!

Uh oh!

Uh oh!

Nightblade May 5, 2026

Uh oh!

Nightblade May 5, 2026

Uh oh!

vaisest May 8, 2026

Uh oh!

vaisest commented May 9, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		local accounts = { elem = "Accounts", attrib = { lastAccountName = self.lastAccountName, lastRealm = self.lastRealm, lastLeague = self.lastLeague, lastToken = self.lastToken, lastRefreshToken = self.lastRefreshToken, tokenExpiry = tostring(self.tokenExpiry) } }
		for accountName, account in pairs(self.gameAccounts) do

Conversation

vaisest commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of the problem being solved:

Steps taken to verify a working solution:

What this PR still needs

Link to a build that showcases this PR:

Before screenshot:

After screenshot:

Uh oh!

vaisest Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

vaisest commented Apr 25, 2026

Uh oh!

vaisest commented Apr 26, 2026

Uh oh!

mcagnion commented Apr 26, 2026

Uh oh!

vaisest commented Apr 26, 2026

Uh oh!

Uh oh!

Uh oh!

Nightblade May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Nightblade May 5, 2026

Choose a reason for hiding this comment

Uh oh!

vaisest May 8, 2026

Choose a reason for hiding this comment

Uh oh!

vaisest commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vaisest commented Apr 24, 2026 •

edited

Loading

vaisest commented May 9, 2026 •

edited

Loading