PS-10970 fix oracle8 compilation#30
Open
lukin-oleksiy wants to merge 1 commit into
Open
Conversation
https://perconadev.atlassian.net/browse/PS-10970 kmipclient: fix OpenSSL version compatibility for Oracle Linux 8 Oracle Linux 8 ships OpenSSL 1.1.1 which lacks two APIs added in later versions: - TLS_method() was introduced in OpenSSL 1.1.0 (ssLv23_method() is the compatible alias for older builds, but also works on 1.1.x) - SSL_get0_peer_certificate() was introduced in OpenSSL 3.0 only; OpenSSL 1.1.x still uses SSL_get_peer_certificate() which bumps the X509 reference count and requires a matching X509_free() Add version-guarded helper functions get_tls_client_method() and get_peer_certificate() that select the correct API at compile time based on OPENSSL_VERSION_NUMBER, and update ensure_tls_peer_verified() and connect() to use them.
lukin-oleksiy
force-pushed
the
PS-10970-fix-oracle8-compilation
branch
from
74f71ab to
27c5898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-10970
kmipclient: fix OpenSSL version compatibility for Oracle Linux 8
Oracle Linux 8 ships OpenSSL 1.1.1 which lacks two APIs added in later versions:
Add version-guarded helper functions get_tls_client_method() and get_peer_certificate() that select the correct API at compile time based on OPENSSL_VERSION_NUMBER, and update ensure_tls_peer_verified() and connect() to use them.