PS-11080: Spoiled logical clock information in rewritten binlog#122
Open
kamil-holubicki wants to merge 1 commit into
Open
PS-11080: Spoiled logical clock information in rewritten binlog#122kamil-holubicki wants to merge 1 commit into
kamil-holubicki wants to merge 1 commit into
Conversation
https://perconadev.atlassian.net/browse/PS-11080 Rewrite mode strips source binlog framing events and merges transactions into local binlog files of configurable size. MySQL's logical clock (sequence_number, last_committed) is defined per physical binlog file on the source. Once those boundaries are removed on the consumer, the raw values from the source are no longer valid: sequence numbers can repeat after each source rotation, and last_committed=0 at a source file boundary no longer implies the same ordering guarantee when everything lives in one local file. Introduce a rewrite-mode GTID renumberer that assigns a monotonic local sequence_number and translates last_committed so dependencies stay within the current local file and cross-source-file ordering is preserved. Support both classic GTID events and GTID_TAGGED_LOG_EVENT, including re-encoding tagged bodies when logical-clock fields change encoded size. Persist enough renumberer state in per-binlog JSON metadata so that after a process restart or a new binsrv invocation the stream can continue appending to the same local file without colliding with sequence numbers already written. Track committed vs in-flight renumberer state so that after a mid-transaction disconnect the discarded partial transaction does not leave recovery metadata pointing past the last completed transaction on disk. Add MTR coverage for coalesced source rotations, local rotation by file size, resume across invocations, and resume after a partial transaction with a deterministic source-side stall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-11080
Rewrite mode strips source binlog framing events and merges transactions into local binlog files of configurable size. MySQL's logical clock (sequence_number, last_committed) is defined per physical binlog file on the source. Once those boundaries are removed on the consumer, the raw values from the source are no longer valid: sequence numbers can repeat after each source rotation, and last_committed=0 at a source file boundary no longer implies the same ordering guarantee when everything lives in one local file.
Introduce a rewrite-mode GTID renumberer that assigns a monotonic local sequence_number and translates last_committed so dependencies stay within the current local file and cross-source-file ordering is preserved. Support both classic GTID events and GTID_TAGGED_LOG_EVENT, including re-encoding tagged bodies when logical-clock fields change encoded size.
Persist enough renumberer state in per-binlog JSON metadata so that after a process restart or a new binsrv invocation the stream can continue appending to the same local file without colliding with sequence numbers already written. Track committed vs in-flight renumberer state so that after a mid-transaction disconnect the discarded partial transaction does not leave recovery metadata pointing past the last completed transaction on disk.
Add MTR coverage for coalesced source rotations, local rotation by file size, resume across invocations, and resume after a partial transaction with a deterministic source-side stall.