Refactor grid view data/layout; remove GridViewDetails

- Remove GridViewDetails; manage column widths/layout in OutGridViewWindow
- Refactor GridViewDataSource: simplify IListDataSource, add viewportX to Render, make MaxItemLength settable
- Replace _listViewSource with _filteredSource for clarity; update filtering and event logic
- Ensure headers and column widths update with data/filter changes
- Remove redundant code and reflection; improve naming and style
- Update Header view for clarity; update launchSettings.json debug profiles
- Comment out Terminal.Gui package reference for manual management

Author: tig

Directory.Packages.props

@@ -3,6 +3,6 @@
     <PackageVersion Include="Microsoft.PowerShell.SDK" Version="7.4.7" />
     <PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
     <PackageVersion Include="System.Management.Automation" Version="7.4.7" />
-    <PackageVersion Include="Terminal.Gui" Version="2.0.0-alpha.3390" />
+    <!--<PackageVersion Include="Terminal.Gui" Version="2.0.0-develop.4947" />-->
   </ItemGroup>
 </Project>

src/Microsoft.PowerShell.ConsoleGuiTools/GridViewDataSource.cs

@@ -5,6 +5,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Collections.Specialized;
+using System.Linq;
 using Terminal.Gui.App;
 using Terminal.Gui.Views;
 
@@ -20,23 +21,17 @@ internal sealed class GridViewDataSource : IListDataSource
     /// </summary>
     public List<GridViewRow> GridViewRowList { get; set; }
 
-    /// <summary>
-    ///     Gets the number of rows in the data source.
-    /// </summary>
+    /// <inheritdoc/>
     public int Count => GridViewRowList.Count;
 
-    /// <inheritdoc />
-    public int MaxItemLength { get; }
+    /// <inheritdoc/>
+    public int MaxItemLength { get; set; }
 
-    /// <summary>
-    ///     Gets or sets a value indicating whether to suspend raising the <see cref="CollectionChanged" /> event.
-    /// </summary>
+    /// <inheritdoc/>
     public bool SuspendCollectionChangedEvent { get; set; }
 
 #pragma warning disable CS0067  
-    /// <summary>
-    ///     Occurs when the collection changes.
-    /// </summary>
+    /// <inheritdoc/>
     public event NotifyCollectionChangedEventHandler? CollectionChanged;
 #pragma warning restore CS0067
 
@@ -49,24 +44,21 @@ public GridViewDataSource(List<GridViewRow> itemList)
         GridViewRowList = itemList;
     }
 
-    /// <summary>
-    ///     Renders a specific item in the list view at the specified position.
-    /// </summary>
-    /// <param name="listView">The list view to render into.</param>
-    /// <param name="selected">A value indicating whether the item is selected.</param>
-    /// <param name="item">The index of the item to render.</param>
-    /// <param name="col">The column position to start rendering.</param>
-    /// <param name="line">The line position to render on.</param>
-    /// <param name="width">The width available for rendering.</param>
-    /// <param name="start">The starting position within the item's display string.</param>
-    public void Render(ListView listView, bool selected, int item, int col, int line, int width, int start = 0)
+    /// <inheritdoc/>
+    public void Render(ListView listView, bool selected, int item, int col, int line, int width, int viewportX)
     {
-        listView.Move(col - start, line);
+        GridViewRow? row = GridViewRowList[item];
+        string displayString = row?.DisplayString ?? string.Empty;
+
+        displayString = viewportX switch
+        {
+            // Truncate the start of the string to skip characters scrolled out of view
+            > 0 when displayString.Length > viewportX => displayString[viewportX..],
+            > 0 when displayString.Length <= viewportX => string.Empty,
+            _ => displayString
+        };
 
-        var driver = listView.App?.Driver;
-        var row = GridViewRowList[item];
-        string displayString = row.DisplayString ?? string.Empty;
-        // Pad right of display string with spaces to fill width
+        // Pad right of display string with spaces to fill width, or truncate if too long
         if (displayString.Length < width)
         {
             displayString = displayString.PadRight(width);
@@ -75,28 +67,17 @@ public void Render(ListView listView, bool selected, int item, int col, int line
         {
             displayString = displayString[..width];
         }
-        driver!.AddStr(displayString);
+
+        listView.AddStr(displayString);
     }
 
-    /// <summary>
-    ///     Determines whether the specified item is marked.
-    /// </summary>
-    /// <param name="item">The index of the item to check.</param>
-    /// <returns><see langword="true" /> if the item is marked; otherwise, <see langword="false" />.</returns>
+    /// <inheritdoc/>
     public bool IsMarked(int item)
     {
-        if (item < 0 || item >= GridViewRowList.Count)
-        {
-            return false;
-        }
-        return GridViewRowList[item].IsMarked;
+        return item < GridViewRowList.Count && GridViewRowList[item].IsMarked;
     }
 
-    /// <summary>
-    ///     Sets the marked state of the specified item and raises the <see cref="MarkChanged" /> event.
-    /// </summary>
-    /// <param name="item">The index of the item to mark or unmark.</param>
-    /// <param name="value"><see langword="true" /> to mark the item; <see langword="false" /> to unmark it.</param>
+    /// <inheritdoc/>
     public void SetMark(int item, bool value)
     {
         var oldValue = GridViewRowList[item].IsMarked;
@@ -143,4 +124,4 @@ public void Dispose()
     {
         // No resources to dispose currently
     }
-}
+}

src/Microsoft.PowerShell.ConsoleGuiTools/GridViewDetails.cs

@@ -2,16 +2,15 @@
 // Licensed under the MIT License.
 
 using System.Collections.Generic;
-using System.Reflection;
-using System.Reflection.PortableExecutable;
 using Terminal.Gui.Drawing;
 using Terminal.Gui.ViewBase;
 using Terminal.Gui.Views;
 
 namespace Microsoft.PowerShell.ConsoleGuiTools;
 
 /// <summary>
-///     A specialized view for displaying grid column headers with individual subviews for each column.
+///     A specialized view for displaying grid column headers with individual subviews for each column. This is added to
+///     the top of the Padding of the ListView.
 /// </summary>
 internal sealed class Header : View
 {
@@ -28,21 +27,20 @@ public override void EndInit()
 
 
         // We are a subview of the ListView.Padding. 
-        if (SuperView is Padding padding)
-        {
-            padding.Parent?.ViewportChanged += ListViewOnViewportChanged;
-        }
+        if (SuperView is Padding padding) padding.Parent?.ViewportChanged += ListViewOnViewportChanged;
+
+        return;
 
         void ListViewOnViewportChanged(object? sender, DrawEventArgs e)
         {
-            if (sender is ListView listView) 
+            if (sender is ListView listView)
                 Viewport = Viewport with { X = listView.Viewport.X };
         }
     }
 
     protected override void OnSubViewLayout(LayoutEventArgs args)
     {
-        if (SuperView is Padding { Parent: ListView listView }) 
+        if (SuperView is Padding { Parent: ListView listView })
             SetContentSize(GetContentSize() with { Width = listView.GetContentSize().Width });
 
         base.OnSubViewLayout(args);