Skip to content

docs: fix grammar and informal language in device sharing guides#393

Open
mesutoezdil wants to merge 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/docs-language-quality
Open

docs: fix grammar and informal language in device sharing guides#393
mesutoezdil wants to merge 1 commit into
Project-HAMi:masterfrom
mesutoezdil:fix/docs-language-quality

Conversation

@mesutoezdil
Copy link
Copy Markdown
Contributor

@mesutoezdil mesutoezdil commented May 17, 2026 •
edited
Loading

  • Fix subject-verb agreement in Vastai guide: provide -> provides
  • Rewrite redundant Vastai capability bullet to be informative rather than circular
  • Remove casual phrasing (you're actually requesting) from Enflame and Iluvatar device granularity sections
  • Replace contractions (don't, you're) with formal equivalents across affected files
  • Rephrase fill in the core and memory values to specify in Iluvatar exclusive-use notes (two example files)

@netlify
Copy link
Copy Markdown

netlify Bot commented May 17, 2026 •
edited
Loading

✅ Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit 376d4c3
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a107bd131fa4b00084c36a7
😎 Deploy Preview https://deploy-preview-393--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hami-robot
Copy link
Copy Markdown
Contributor

hami-robot Bot commented May 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mesutoezdil
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot Bot requested review from archlitchi and rootsongjc May 17, 2026 21:41
@hami-robot hami-robot Bot added the size/S label May 17, 2026
@windsonsea
Copy link
Copy Markdown
Member

windsonsea commented May 20, 2026

Don't know why all CI failed in current PRs.

@mesutoezdil
Copy link
Copy Markdown
Contributor Author

mesutoezdil commented May 20, 2026

Don't know why all CI failed in current PRs.

I don’t think the problem stems from me; sth like this happened on @rootsongjc before.
As the PRs haven’t been merged, I haven’t opened a new PR either.

@mesutoezdil
docs: fix grammar and informal language in device sharing guides
376d4c3 
- Fix subject-verb agreement in vastai guide ("provide" -> "provides")
- Rewrite redundant vastai capability description to be informative
- Remove casual "you're actually" phrasing in enflame and iluvatar docs
- Replace contractions and informal phrasing with formal equivalents
- Rephrase "fill in" to "specify" in iluvatar exclusive-use notes

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil mesutoezdil force-pushed the fix/docs-language-quality branch from 1bd57b6 to 376d4c3 Compare May 22, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@archlitchi archlitchi Awaiting requested review from archlitchi

@rootsongjc rootsongjc Awaiting requested review from rootsongjc

Assignees

No one assigned

Labels

dco-signoff: yes size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mesutoezdil @windsonsea