Skip to content
Closed
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/pythonapp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,8 @@ jobs:
- name: Install the dependencies
run: |
python -m pip install --user --upgrade pip wheel
python -m pip install torch==2.5.1 torchvision==0.20.1
cat "requirements-dev.txt"
python -m pip install -r requirements-dev.txt
python -m pip install torch==2.5.1 torchvision==0.20.1 -r requirements-dev.txt
Comment thread
ericspod marked this conversation as resolved.
Outdated
python -m pip list
python setup.py develop # test no compile installation
shell: bash
Expand Down
5 changes: 3 additions & 2 deletions monai/transforms/signal/array.py
Original file line number Diff line number Diff line change
Expand Up @@ -411,10 +411,11 @@ def __call__(self, signal: np.ndarray) -> Any:
Args:
signal: signal to be frequency removed
"""
signal = convert_to_tensor(signal, dtype=torch.double)
b_notch, a_notch = convert_to_tensor(
iirnotch(self.frequency, self.quality_factor, self.sampling_freq), dtype=torch.float
iirnotch(self.frequency, self.quality_factor, self.sampling_freq), dtype=torch.double
)
y_notched = filtfilt(convert_to_tensor(signal), a_notch, b_notch)
y_notched = filtfilt(signal, a_notch, b_notch)

return y_notched

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
requires = [
"wheel",
"setuptools",
"torch>=2.4.1",
"torch>=2.5.1",
"ninja",
"packaging"
]
Expand Down
1 change: 1 addition & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Full requirements for developments
-r requirements-min.txt
pytorch-ignite==0.4.11
torchaudio
Comment thread
ericspod marked this conversation as resolved.
Outdated
gdown>=4.7.3
scipy>=1.12.0; python_version >= '3.9'
itk>=5.2
Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
torch>=2.4.1; platform_system != "Windows"
torch>=2.4.1, !=2.7.0; platform_system == "Windows"
torch>=2.5.1; platform_system != "Windows"
torch>=2.5.1, !=2.7.0; platform_system == "Windows"
Comment thread
ericspod marked this conversation as resolved.
numpy>=1.24,<3.0
4 changes: 3 additions & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ setup_requires =
ninja
packaging
install_requires =
torch>=2.4.1
torch>=2.5.1
numpy>=1.24,<3.0
Comment thread
ericspod marked this conversation as resolved.

[options.extras_require]
Expand Down Expand Up @@ -108,6 +108,8 @@ torchio =
torchio
torchvision =
torchvision
torchaudio =
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this requirement? It will let the ci always downloading the latest pytorch.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll remove the requirement now and we'll try blossom again.

torchaudio
itk =
itk>=5.2
tqdm =
Expand Down
Loading