Skip to content

fix: support transaction overrides in fulfillOrders#876

Open
aproskill81 wants to merge 1 commit into
ProjectOpenSea:mainfrom
aproskill81:fix/fulfill-orders-overrides
Open

fix: support transaction overrides in fulfillOrders#876
aproskill81 wants to merge 1 commit into
ProjectOpenSea:mainfrom
aproskill81:fix/fulfill-orders-overrides

Conversation

@aproskill81
Copy link
Copy Markdown

Motivation

fulfillOrders did not expose transaction overrides even though fulfillOrder already supports them. This prevented callers from setting transaction-level fields such as gasLimit, nonce, or fee overrides when fulfilling multiple orders.

Solution

Add overrides to the fulfillOrders input and pass it through to fulfillAvailableOrders.

The final transaction overrides preserve the SDK-calculated native token value while forwarding caller-provided fields. Added coverage that verifies a provided gasLimit is included in the built fulfillment transaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant