Conversation
Now the readMe can be easily pushed to github with the new leetcode Here are features which are currently extracted * Problem Title * Problem Link * Problem Statement * Problem Description * Language used by the user * Submission stats
Now the code can be easily pushed as well The Code and the ReadMe(question statement) can be pushed to github, All the features are extracted. Notes/Discussions are not extracted
Fixed repeatly uploading of files Currently one file/solution can be pushed one time.
|
@QasimWani would you please review this? |
| @@ -0,0 +1,535 @@ | |||
| /* Enum for languages supported by LeetCode. */ | |||
| const programmingLanguages = { | |||
| Python: '.py', | |||
There was a problem hiding this comment.
what are the changes done in this js file?
There was a problem hiding this comment.
These were basically DOM manipulation changes that I fixed with the new UI, but since i had to run it parallel with the old UI, i made a new file called newleetcode.js, which had the same boilerplate as leetcode.js , the old UI file, but with different methods and member functions. There is one major problem as discussed in the PR, which if someone helps me with, I can fix it. I have found the fix for difficulty tag of the problem and this can be migrated to v3 in the next PR, but for now, i want to address the 2nd issue.
Feel free to merge this in the dev branch, and later we can merge it to main
There was a problem hiding this comment.
hey @sandeepk97 what do u think about merging these changes?
|
Any update on this MR? |
|
Any updates? Looks like there are two competing PRs to fix this, the other had some activity from the author last month |
|
This PR was never reviewed, so there was no further development. :( |
|
hey @abhinav7sinha, thanks for approving the changes.. if there's still no progress on this issue.. i can update this PR, and start working on this. although merging is blocked and requires a review from those with write access |
Oh, right @varun-s22 I don't think it's a good idea to work on it until someone with write access approves it. Hopefully, it happens soon. This is a fairly useful project, and it will be a shame if it's not maintained well |
Here is a temporary solution to this problem, using merely DOM manipulation.
I tried to edit the code in the same file, but there were some functions which are not written asynchronously, but their intended work is the to produce the async effect.
I created a new file called
newLeetcode.js, which has all these synchronous functions, for the newer version of Leetcode,There are certain major updates awaiting this like:
setTimeOut,setInterval, etc and making them async functionsBut currently here is the future work, as this solution lacks these features:
Notes.mdis not supported.The problems faced are:
successTaghas only 1 class, and then after submission 2 classes are present. We can catch the one time uploading here (in the previous UI), but in this new UI, we don't have such a element to have a check. One workaround solution was to keep a check oncodeelement, and the re-routing, as the page re-routes first, and then loads these components, so we may have a window for one-time execution, but again we were fetching the language/statistics of the solution, from the solution page, and so this fails.local undefinederror inchrome.storage.local.These issues/future work shall be addressed in a new PR, but for the time being, here is the output