Skip to content

[lint] For infosec team, use read to iterate over files #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpalermo merged 2 commits into from
Apr 30, 2026
Merged

[lint] For infosec team, use read to iterate over files #2208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c33153
[lint] For infosec team, use read to iterate over files
dpalermo Apr 30, 2026
f82dd4a
Change file separator to newline
dpalermo Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/aomp-shell.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
id: changed-files
uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323
with:
separator: ' '
separator: '\n'
skip_initial_fetch: true
base_sha: 'HEAD~1'
sha: 'HEAD'
Expand All @@ -29,8 +29,8 @@ jobs:
- name: Run shellcheck
run: |
shellcheck_status=0
for file in ${{ steps.changed-files.outputs.all_changed_files }}; do
if [[ $file == *.sh ]] || [[ $(file "$file") =~ "shell script" ]]; then
while read -r file; do
if [[ "$file" == *.sh ]] || [[ $(file "$file") =~ "shell script" ]]; then
file_dir=$(dirname "$file")
file_name=$(basename "$file")

Expand All @@ -43,6 +43,6 @@ jobs:

popd || exit 1
fi
done
done <<< "${{ steps.changed-files.outputs.all_changed_files }}"
exit $shellcheck_status
shell: bash {0}