[Offload][AMDGPU][NFC] Improve message for warning non-XNACK runs#2345
Merged
Conversation
Collaborator
jplehr
reviewed
Apr 29, 2026
jplehr
left a comment
jplehr
left a comment
There was a problem hiding this comment.
I think that change makes sense to improve communication to users.
| "re-run with HSA_XNACK=1. If your device does not support XNACK, " | ||
| "remove USM pragma and use map clauses instead. " | ||
| "Set OMPX_EAGER_ZERO_COPY_MAPS=1 for optimal zero-copy " | ||
| "performance on non-XNACK APUs."); |
There was a problem hiding this comment.
Suggested change
| "performance on non-XNACK APUs."); | |
| "performance on non-XNACK shared-memory devices."); |
I don't know whether we should use the term APU here. I don't have a strong opinion either.
Collaborator
Author
|
Updated the USM tests to address the CI failure: ROCm/aomp#2206 |
Collaborator
|
!PSDB |
Collaborator
ronlieb
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to provide detailed warning message for guiding users when running USM kernels on the non-XNACK APUs.