Modified SLD profiles.#440
Open
arwelHughes wants to merge 6 commits into
Open
Conversation
…ign on the substrates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in RasCAL2:
Issue 215: This bug was caused by the total range for the SLD plots not being sufficient when large roughness' are used in the last layer if standard layer models. 'makeSLDProfile' has been modified to extend the range of the profile to cover the 99% interval of the outer error function.
Issue 205: SLD profiles should always be aligned to the substrate edge. This happens automatically for substrate/liquid profiles, but for air/substrate samples should be aligned to the other end. To fix this, 'plotRefSLD' has been modified to align the substrates in A/L projects by padding the start of the SLD's.