Skip to content

update to work with Godot 4.1+#16

Merged
RedMser merged 6 commits intoRedMser:masterfrom
3ddelano:feat_godot_4_1
Sep 7, 2025
Merged

update to work with Godot 4.1+#16
RedMser merged 6 commits intoRedMser:masterfrom
3ddelano:feat_godot_4_1

Conversation

@3ddelano
Copy link
Copy Markdown
Contributor

@3ddelano 3ddelano commented Sep 7, 2025

closes #15

Tested on Godot 4.5 beta6.

image

@RedMser
Copy link
Copy Markdown
Owner

RedMser commented Sep 7, 2025

Thanks for the PR! :)

It seems like the CI build actions are stuck, that might be because of the CI being configured with a too old version of runners?

See build.yml, could you try changing the ubuntu version from ubuntu-20.04 to ubuntu-latest?

@3ddelano
Copy link
Copy Markdown
Contributor Author

3ddelano commented Sep 7, 2025

Sure will try that

@3ddelano
Copy link
Copy Markdown
Contributor Author

3ddelano commented Sep 7, 2025

Fixing a couple more github action changes

@RedMser
Copy link
Copy Markdown
Owner

RedMser commented Sep 7, 2025

Hmm I think this would still error because github.event.repository.name contains a slash, which upload-artifact does not like. You could replace that part with hard-coded godot-embed-external-editor tbh. Not sure what the download-artifact would do here.

Comment thread .github/workflows/build.yml Outdated
3ddelano and others added 2 commits September 7, 2025 19:20
Co-authored-by: RedMser <5117197+RedMser@users.noreply.github.com>
@RedMser
Copy link
Copy Markdown
Owner

RedMser commented Sep 7, 2025

Aghh CI is annoying to debug, haha sorry for this back and forth... thanks for sticking with me here :)

@RedMser RedMser merged commit 909a39a into RedMser:master Sep 7, 2025
2 checks passed
@3ddelano 3ddelano deleted the feat_godot_4_1 branch September 7, 2025 14:08
@RedMser
Copy link
Copy Markdown
Owner

RedMser commented Sep 7, 2025

Awesome! Thanks for contributing.

The artifact file names are a bit ugly now, but it doesn't matter much, I'll make an issue if someone wants to deal with CI some more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Godot 4.1+ support

2 participants