Skip to content

bump rust-version to 1.85.0 + use Rust edition 2024 + apply new formatting#106

Merged
Robbepop merged 4 commits into
Robbepop:masterfrom
xtqqczze:msrv185
May 6, 2026
Merged

bump rust-version to 1.85.0 + use Rust edition 2024 + apply new formatting#106
Robbepop merged 4 commits into
Robbepop:masterfrom
xtqqczze:msrv185

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented May 1, 2026

Closes #99

criterion v0.8 introduces an MSRV of 1.86, so this development dependency was not upgraded.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.06%. Comparing base (6897b32) to head (972af49).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   61.06%   61.06%           
=======================================
  Files          12       12           
  Lines         506      506           
=======================================
  Hits          309      309           
  Misses        197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop
Copy link
Copy Markdown
Owner

Robbepop commented May 1, 2026

@xtqqczze thank you for the PR!

criterion v0.8 introduces an MSRV of 1.86 [..]

Then why not upgrade MSRV to 1.86 directly?

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented May 1, 2026

Then why not upgrade MSRV to 1.86 directly?

I didn't want to block hashbrown v0.17.0 for crates still on 1.85.

However since dev-dependencies are not used when compiling a package for building, it might be OK to upgrade criterion while keeping MSRV of 1.85?

@Robbepop
Copy link
Copy Markdown
Owner

Robbepop commented May 1, 2026

@xtqqczze I thought we released v0.20 so that we can make a clean cut. People relying on an older Rust version can still depend on v0.20.

Rust 1.85 was released on Feb. 20, 2025. Quite some time to adjust your own toolchain in my honest opinion. :)

@jgabaut
Copy link
Copy Markdown

jgabaut commented May 6, 2026

@xtqqczze I thought we released v0.20 so that we can make a clean cut. People relying on an older Rust version can still depend on v0.20.

Rust 1.85 was released on Feb. 20, 2025. Quite some time to adjust your own toolchain in my honest opinion. :)

I do agree, does this mean till could get merged soon?
While I don't care about the edition bump to 2024 in this PR, closing the issue for the outdated hashbrown would be nice.

Copy link
Copy Markdown
Owner

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you for the PR!
Next time please put formatting changes in a separate PR even if that means that CI won't be happy for one PR. Makes otherwise trivial changes harder to review.

@Robbepop Robbepop changed the title bump rust-version to 1.85.0 bump rust-version to 1.85.0 + use Rust edition 2024 + apply new formatting May 6, 2026
@Robbepop Robbepop merged commit db24792 into Robbepop:master May 6, 2026
15 of 16 checks passed
@xtqqczze xtqqczze deleted the msrv185 branch May 8, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Out of date dependencies

4 participants