bump rust-version to 1.85.0 + use Rust edition 2024 + apply new formatting#106
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #106 +/- ##
=======================================
Coverage 61.06% 61.06%
=======================================
Files 12 12
Lines 506 506
=======================================
Hits 309 309
Misses 197 197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@xtqqczze thank you for the PR!
Then why not upgrade MSRV to 1.86 directly? |
I didn't want to block hashbrown v0.17.0 for crates still on 1.85. However since dev-dependencies are not used when compiling a package for building, it might be OK to upgrade |
|
@xtqqczze I thought we released v0.20 so that we can make a clean cut. People relying on an older Rust version can still depend on v0.20. Rust 1.85 was released on Feb. 20, 2025. Quite some time to adjust your own toolchain in my honest opinion. :) |
I do agree, does this mean till could get merged soon? |
Robbepop
left a comment
There was a problem hiding this comment.
LGTM and thank you for the PR!
Next time please put formatting changes in a separate PR even if that means that CI won't be happy for one PR. Makes otherwise trivial changes harder to review.
Closes #99
criterion v0.8 introduces an MSRV of 1.86, so this development dependency was not upgraded.