Various UI Consistency Fixes#66
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes button styling across the application: icon-only action buttons are converted from mat-stroked-button (with anchor tags) to mat-icon-button with consistent SVG icons and color classes (blue for new, cyan for edit, red for delete, green for save), and a global SCSS override is added to restore primary/warn flat/raised button theming after Angular Material v21 dropped the M2 color input.
Changes:
- Standardize icon-button visuals (icons, colors, element type) across many feature pages.
- Add global CSS to re-apply primary/warn background and disabled styling for
mat-flat-button/mat-raised-button. - Demote some non-primary actions (Test Connection, Reset, Cancel/Discard, Import Submissions) from
color="accent"raised/flat buttons to plainmat-stroked-button.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/styles.scss | Adds global override restoring primary/warn theming for Material flat/raised buttons. |
| src/app/modules/organizations/settings/salesforce/salesforce.component.html | Converts secondary actions to stroked and table actions to icon buttons. |
| src/app/modules/organizations/settings/audit-template/audit-template.component.html | Demotes Import Submissions to stroked. |
| src/app/modules/organizations/members/members.component.html | Standardizes edit/delete row actions. |
| src/app/modules/organizations/labels/labels.component.html | Standardizes edit/delete row actions. |
| src/app/modules/organizations/email-templates/email-templates.component.html | Standardizes template action icons; updates Create button icon. |
| src/app/modules/organizations/derived-columns/modal/form-modal.component.html | Standardizes delete and add-parameter icons. |
| src/app/modules/organizations/derived-columns/derived-columns.component.html | Standardizes edit/delete row actions. |
| src/app/modules/organizations/data-quality/inventory/inventory-table.component.html | Standardizes edit/delete row actions. |
| src/app/modules/organizations/data-quality/goal/goal-table.component.html | Standardizes edit/delete row actions. |
| src/app/modules/organizations/cycles/cycles.component.html | Standardizes edit/delete row actions. |
| src/app/modules/organizations/columns/matching-criteria/criteria-list.component.html | Converts remove action to icon button. |
| src/app/modules/organizations/columns/mappings/modal/create-modal.component.html | Standardizes remove icon and add-row icon. |
| src/app/modules/organizations/columns/mappings/mappings.component.html | Reworks profile action toolbar to icon buttons; demotes Discard to stroked. |
| src/app/modules/organizations/columns/mappings/action-buttons.component.html | Standardizes edit/delete icon buttons. |
| src/app/modules/organizations/columns/list/list.component.html | Standardizes edit/rename/delete actions. |
| src/app/modules/organizations/columns/import-settings/import-settings.component.html | Converts remove actions to icon buttons; demotes secondary buttons to stroked. |
| src/app/modules/organizations/columns/geocoding/geocoding.component.html | Converts remove and add buttons. |
| src/app/modules/inventory-list/list/grid/filter-group/filter-group-selector.component.html | Updates filter group toolbar icons and sizing. |
| src/app/modules/insights/property-insights/property-insights.component.html | Removes border styling class from toggle group. |
| src/app/modules/insights/default-reports/default-reports.component.html | Adds color classes to standardized icons. |
| src/app/modules/insights/custom-reports/custom-reports.component.html | Removes inline list delete buttons; standardizes Actions panel icons. |
| src/app/modules/datasets/datasets.component.ts | Updates inline rename/delete icons in the dataset tree to colored versions. |
| src/app/modules/datasets/data-mappings/step1/map-data.component.html | Converts profile actions to icon buttons. |
| src/@seed/components/column-profiles/column-profiles.component.html | Converts profile toolbar actions to icon buttons with standardized icons. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizes icon buttons, primary action buttons, and secondary action buttons across the entire
application for a consistent look and feel.
Established and applied consistent icon button standards across all pages:
│ New/Add │ fa-solid:plus │ Blue (fill-primary-700) │
│ Edit/Rename │ fa-solid:pencil │ Cyan (fill-cyan-600) │
│ Delete │ fa-solid:trash │ Red (fill-red-700) │
│ Save │ fa-solid:floppy-disk │ Green (fill-green-700) │
outline) for cleaner appearance
column list, cycles, data quality, labels, members, derived columns, email templates, import settings,
geocoding, matching criteria, salesforce, datasets, and data mappings
Primary Action Button Theming Fix
color="warn" — Angular Material v21 dropped the M2 color input on buttons, so these were rendering as
unstyled text
white text