Skip to content

Chore: Remove obsolete warning when converting a dbt project #4685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
izeigerman merged 2 commits into from
Jun 6, 2025
Merged

Chore: Remove obsolete warning when converting a dbt project #4685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c47445c
Chore: Remove obsolete warning when converting a dbt project
izeigerman Jun 6, 2025
fb5a1c1
fix test
izeigerman Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions sqlmesh/dbt/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,14 +314,6 @@ def model_kind(self, context: DbtContext) -> ModelKind:
**incremental_by_kind_kwargs,
)

incremental_by_time_str = collection_to_str(INCREMENTAL_BY_TIME_STRATEGIES)
incremental_by_unique_key_str = collection_to_str(
INCREMENTAL_BY_UNIQUE_KEY_STRATEGIES.union(["none"])
)
get_console().log_warning(
f"Using unmanaged incremental materialization for model '{self.canonical_name(context)}'. "
f"Some features might not be available. Consider adding either a time_column ({incremental_by_time_str}) or a unique_key ({incremental_by_unique_key_str}) configuration to mitigate this.",
)
strategy = self.incremental_strategy or target.default_incremental_strategy(
IncrementalUnmanagedKind
)
Expand Down
1 change: 0 additions & 1 deletion tests/dbt/test_transformation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1314,7 +1314,6 @@ def test_clickhouse_properties(mocker: MockerFixture):
"SQLMesh does not support 'incremental_predicates' - they will not be applied.",
"SQLMesh does not support the 'query_settings' model configuration parameter. Specify the query settings directly in the model query.",
"SQLMesh does not support the 'sharding_key' model configuration parameter or distributed materializations.",
"Using unmanaged incremental materialization for model '`test`.`model`'. Some features might not be available. Consider adding either a time_column ('delete+insert', 'insert_overwrite') or a unique_key ('merge', 'none') configuration to mitigate this.",
]

assert [e.sql("clickhouse") for e in model_to_sqlmesh.partitioned_by] == [
Expand Down