feat(lsp): model descriptions in LSP completions#4713
Merged
Conversation
benfdking
force-pushed
the
codex/add-completion-details-for-models
branch
from
36e8c54 to
fc2af07
Compare
benfdking
force-pushed
the
codex/add-completion-details-for-models
branch
from
fc2af07 to
264e398
Compare
benfdking
changed the title
benfdking
changed the title
themisvaltinos
approved these changes
Jun 11, 2025
Collaborator
themisvaltinos
left a comment
themisvaltinos
left a comment
There was a problem hiding this comment.
lgtm just a minor nit in the code. also why did you end up removing the e2e test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AllModelsResponseTesting
ruff check sqlmesh/lsp/custom.py sqlmesh/lsp/completions.py sqlmesh/lsp/main.pymypy sqlmesh/lsp/custom.py sqlmesh/lsp/completions.py sqlmesh/lsp/main.pypnpm exec eslint src/lsp/custom.ts src/completion/completion.tspytest(fails: tests/cli/test_cli.py::test_environments, tests/cli/test_cli.py::test_state_export_specific_environments, tests/cli/test_cli.py::test_state_import_replace)https://chatgpt.com/codex/tasks/task_e_68494c6469888330a33c1f2fcd3b556c