fix(vscode): include process path env variable in passed path#4770
Merged
fix(vscode): include process path env variable in passed path#4770
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the interpreter’s bin directory is prepended to the system PATH when invoking SQLMesh commands, so any required binaries are resolvable at runtime.
- Prepend
interpreterDetails.binPathto the existingPATHinstead of overriding it - Applied this change in three execution helpers:
getTcloudBin,sqlmeshExec, andsqlmeshLspExec
Comments suppressed due to low confidence (1)
vscode/extension/src/utilities/sqlmesh/sqlmesh.ts:86
- There are no existing tests validating that the PATH string correctly prepends the interpreter bin directory to the original PATH. Consider adding a unit test for the helper (once extracted) to assert this behavior.
PATH: `${interpreterDetails.binPath!}${path.delimiter}${process.env.PATH || ''}`,
georgesittas
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PATHenv variable, whereas we should be pretending it with the value rather than overriding.