Feat: Add support for dot env file to load variables from#4840
Merged
themisvaltinos merged 3 commits intomainfrom Jun 30, 2025
Merged
Feat: Add support for dot env file to load variables from#4840themisvaltinos merged 3 commits intomainfrom
themisvaltinos merged 3 commits intomainfrom
Conversation
izeigerman
reviewed
Jun 27, 2025
izeigerman
approved these changes
Jun 27, 2025
07da225 to
375e910
Compare
| "PyAthena[Pandas]", | ||
| "PyGithub>=2.6.0", | ||
| "pyperf", | ||
| "python-dotenv", |
Collaborator
There was a problem hiding this comment.
@themisvaltinos we need to move this to dependencies– this isn't a dev dependency, because the .env functionality requires that this package is installed on the user's system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update allows environment variables being loaded from a
.envfile in the project directory, fixes: #4405Example
.envfile:SNOWFLAKE_PW=my_secret_password S3_BUCKET=s3://my-data-bucket/warehouse # Override SQLMesh config values SQLMESH__DEFAULT_GATEWAY=production SQLMESH__MODEL_DEFAULTS__DIALECT=snowflake