Skip to content

chore(vscode): move to better exec async #4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benfdking merged 1 commit into from
Jul 3, 2025
Merged

chore(vscode): move to better exec async #4884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions vscode/extension/tests/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import path from 'path'
import { Page } from '@playwright/test'
import { exec } from 'child_process'
import { promisify } from 'util'
import { execAsync } from '../src/utilities/exec'

// Where your extension lives on disk
export const EXT_PATH = path.resolve(__dirname, '..')
Expand Down Expand Up @@ -34,8 +33,6 @@ export const clickExplorerTab = async (page: Page): Promise<void> => {
}
}

const execAsync = promisify(exec)

export interface PythonEnvironment {
pythonPath: string
pipPath: string
Expand All @@ -49,8 +46,10 @@ export const createVirtualEnvironment = async (
venvDir: string,
): Promise<PythonEnvironment> => {
const pythonCmd = process.platform === 'win32' ? 'python' : 'python3'
const { stderr } = await execAsync(`${pythonCmd} -m venv "${venvDir}"`)
if (stderr && !stderr.includes('WARNING')) {
const { stderr, exitCode } = await execAsync(
`${pythonCmd} -m venv "${venvDir}"`,
)
if (exitCode !== 0) {
throw new Error(`Failed to create venv: ${stderr}`)
}
// Get paths
Expand All @@ -76,8 +75,8 @@ export const pipInstall = async (
): Promise<void> => {
const { pipPath } = pythonDetails
const execString = `"${pipPath}" install -e "${packagePaths.join('" -e "')}"`
const { stderr } = await execAsync(execString)
if (stderr && !stderr.includes('WARNING') && !stderr.includes('notice')) {
const { stderr, exitCode } = await execAsync(execString)
if (exitCode !== 0) {
throw new Error(`Failed to install package: ${stderr}`)
}
}
Expand Down
Loading