fix(bookmarks): open bookmark panel from reminder tap and fix tombstone purge#818
Closed
Just-Insane wants to merge 2 commits into
Closed
fix(bookmarks): open bookmark panel from reminder tap and fix tombstone purge#818Just-Insane wants to merge 2 commits into
Just-Insane wants to merge 2 commits into
Conversation
After checkDueReminders fires a bookmark reminder notification, the SW
persists only the remaining (non-due) reminders to its cache — but
useReminderSync would immediately overwrite that cache by pushing the
full list from Matrix account data (which hadn't been updated).
Fix: the SW now posts a { type: 'remindersFired', bookmarkIds } message
to all open window clients after firing. useReminderSync listens for
this message and calls clearBookmarkReminder for each fired ID, updating
account data so the next syncReminders call pushes the correct subset.
…nimal purge tombstone
- sw.ts: include isReminder in the notificationClick postMessage so the
running app can handle reminder taps correctly without falling through
to the "no roomId" early return.
- ClientNonUIFeatures.tsx: HandleNotificationClick now opens the
bookmarks panel (bookmarksPanelAtom) when isReminder is true, instead
of doing nothing (previously bailed out at the !roomId guard).
- bookmarkRepository.ts: purgeBookmark now writes the minimal tombstone
{ deleted: true, purged: true } instead of spreading the original
bookmark content. The original room/event metadata no longer lingers
in account data after a permanent archive deletion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing — these commits have been cherry-picked into feat/message-bookmarks (#601).