Skip to content

fix: read wRTC dashboard fixtures as UTF-8 #4876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Asti1982 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: read wRTC dashboard fixtures as UTF-8 #4876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tools/wrtc-bridge-dashboard/test_bridge_dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/usr/bin/env python3
# SPDX-License-Identifier: MIT
"""
Tests for wRTC Bridge Dashboard
Run: python -m pytest tools/wrtc-bridge-dashboard/test_bridge_dashboard.py -v
Expand All @@ -14,7 +15,7 @@
class TestHTMLStructure(unittest.TestCase):
@classmethod
def setUpClass(cls):
with open(os.path.join(HERE, "index.html")) as f:
with open(os.path.join(HERE, "index.html"), encoding="utf-8") as f:
cls.html = f.read()

def test_has_title(self):
Expand Down Expand Up @@ -54,7 +55,7 @@ def test_no_external_deps(self):
class TestJSStructure(unittest.TestCase):
@classmethod
def setUpClass(cls):
with open(os.path.join(HERE, "bridge_dashboard.js")) as f:
with open(os.path.join(HERE, "bridge_dashboard.js"), encoding="utf-8") as f:
cls.js = f.read()

def test_rustchain_api(self):
Expand Down Expand Up @@ -121,7 +122,7 @@ def test_no_build_required(self):
self.assertFalse(os.path.exists(os.path.join(HERE, "package.json")))

def test_valid_html(self):
with open(os.path.join(HERE, "index.html")) as f:
with open(os.path.join(HERE, "index.html"), encoding="utf-8") as f:
html = f.read()
self.assertIn("<!DOCTYPE html>", html)
self.assertIn("</html>", html)
Expand Down
Loading