Open
Conversation
gonzaloriestra
force-pushed
the
river/use-jwt-dest-for-token-exchange
branch
from
aaf2cc7 to
7992177
Compare
lizkenyon
reviewed
Apr 9, 2026
zzooeeyy
reviewed
Apr 9, 2026
|
|
||
| module ShopifyAPI | ||
| module Utils | ||
| class ShopValidator |
Contributor
There was a problem hiding this comment.
There's also a similar sanitize method from shopify_app gem, I wonder if the logic can be extracted so we don't have to maintain 2 packages for validating Shopify URLS
Author
There was a problem hiding this comment.
I've finally copied the code from there. Once we release a new version, we could use it from shopify_app, as it's already using shopify-api-ruby. Makes sense?
gonzaloriestra
force-pushed
the
river/use-jwt-dest-for-token-exchange
branch
from
7992177 to
66cb7f4
Compare
gonzaloriestra
force-pushed
the
river/use-jwt-dest-for-token-exchange
branch
from
66cb7f4 to
d51f23a
Compare
lizkenyon
reviewed
Apr 14, 2026
| requested_token_type: RequestedTokenType, | ||
| ).returns(ShopifyAPI::Auth::Session) | ||
| end | ||
| def exchange_token(shop:, session_token:, requested_token_type:) |
Contributor
There was a problem hiding this comment.
I would prefer we don't remove this in this PR. But rather log a warning that this will be remove in a future version. i.e we should deprecate now remove later.
This will allow us to group our breaking changes together.
ShopifyAPI::Logger.deprecated(
"The `shop` parameter for `exchange_token` is deprecated and will be removed in v17. " \
"The shop is now always taken from the session token's `dest` claim.",
"17.0.0"
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://docs.google.com/document/d/1c0iXhKBpm-yhvff0iSgq1XwBSPL39fTBVajIJ3svaxU/edit?usp=sharing
Checklist: