Implement ty fixes#586
Merged
Merged
Conversation
svij-sc
requested review from
kmontemayor2-sc,
mkolodner-sc,
nshah-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
Fixes all type errors found by ty after the mypy→ty migration: - Remove redundant cast() calls (graph_data_types.py, eval_metrics.py) - Fix `raise NotImplemented` → `raise NotImplementedError` (graph_dataset.py) - Add explicit `import concurrent.futures` and `import absl.logging` - Use `isinstance()` instead of `type() ==` for proper type narrowing (file_loader.py) - Remove _Comparable protocol bound from SortedDict (sorted_dict.py) - Add ty: ignore comments for unresolvable type narrowing cases - Promote all ty rules back to default error severity - Add overrides to suppress errors in generated *_pb2.py files - Exclude notebooks from type checking Co-Authored-By: shubhamvij <25601958+shubhamvij@users.noreply.github.com>
svij-sc
force-pushed
the
svij/use-ty-fixes
branch
from
ad2986a to
43536db
Compare
|
Semgrep found 1 Using variable interpolation |
Co-authored-by: kmontemayor <kyle.e.montemayor@gmail.com> Co-authored-by: svij <svij@snapchat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ty was introduced here: #585
This PR introduces relevant fixes for type check to pass.