feat: improve valdi-tsx skill score from 10% to 89%#96
Closed
yogesh-tessl wants to merge 1 commit into
Closed
Conversation
Hey @cholgateSC 👋 I ran your skills through `tessl skill review` at work and found some targeted improvements for `valdi-tsx` — your core TSX component authoring skill. Here's the before/after: | Skill | Before | After | Change | |-------|--------|-------|--------| | valdi-tsx | 10% | 89% | +79% | All 27 skills in the repo scored 10% baseline because they're missing YAML frontmatter (the `---` block with `name` and `description` fields that skill routers use for matching). I picked `valdi-tsx` to improve first since it's the most central skill — it's the one every Valdi developer hits when writing components. <details> <summary>Changes made</summary> **Frontmatter (biggest impact — unlocks skill routing):** - Added YAML frontmatter with `name: valdi-tsx` and a rich `description` field listing specific capabilities (StatefulComponent lifecycle, setState, viewModel, type-safe styling, provider DI, event handling) and explicit trigger file paths **Structural improvements:** - Added a **New Component Checklist** — a 9-step workflow from file creation through build verification with error recovery guidance for common build failures - Condensed verbose styling subsections (Spacing, Layout, Position & Size, Common Properties) into a compact reference summary with a pointer to the full API docs - Consolidated the 18-item "Common Mistakes" list into a focused "Additional Pitfalls" section covering only the non-obvious gotchas not already shown inline (SIGIcon typing, ShapeView imports, per-side borders, ViewModel name collisions) - Trimmed redundant prose paragraphs that restated what the ❌/✅ code comments already showed **What stayed the same:** - All existing code examples, the React vs Valdi comparison table, provider pattern, event handling, and platform detection sections are preserved - No content was removed that wasn't already covered elsewhere in the skill </details> I also stress-tested your `valdi-tsx` skill against a task eval that asked an agent to build a stateful counter with provider-injected services — it correctly used `StatefulComponent` with `setState()` and the `withProviders` HOC pattern instead of falling back to React hooks. Solid work on the anti-hallucination guidance. ## Type of Change - [x] Documentation improvement ## Testing - [x] Ran `tessl skill review` before and after changes to verify score improvement (10% → 89%) - [x] Verified all validation checks pass with no errors or warnings ## Checklist - [x] Code follows project style guidelines - [x] No breaking changes - [x] No secrets, API keys, or internal URLs included Honest disclosure — I work at @tesslio where we build tooling around skills like these. Not a pitch — just saw room for improvement and wanted to contribute. Want to self-improve your skills? Just point your agent (Claude Code, Codex, etc.) at [this Tessl guide](https://docs.tessl.io/evaluate/optimize-a-skill-using-best-practices) and ask it to optimize your skill. Ping me — [@yogesh-tessl](https://github.com/yogesh-tessl) — if you hit any snags. Thanks in advance 🙏
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎉 Thanks for your first contribution to Valdi!
A maintainer will review your PR soon. Here are a few things to check while you wait:
- ✅ All tests pass (
bazel test //...) - ✅ Your changes follow our coding standards
- ✅ You've added tests for your changes (if applicable)
- ✅ You've updated documentation (if needed)
Join our Discord community if you have questions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @cholgateSC 👋
this is seriously impressive work. Having 27 skills backed by a dedicated
CONTRIBUTING_SKILLS.mdandregistry.jsonmakes the whole collection feel very well organized and intentional. The granularity is especially strong breaking things out into gestures, animations, error handling, and even mock-to-module workflows shows a real understanding of day-to-day development needs.ran your skills through
tessl skill reviewat work and found some targeted improvements forvaldi-tsx. Your core TSX component authoring skill. Here's the before/after:All 27 skills in the repo scored 10% baseline because they're missing YAML frontmatter (the
---block withnameanddescriptionfields that skill routers use for matching). I pickedvaldi-tsxto improve first since it's the most central skill. It's the one every Valdi developer hits when writing components.Changes made
Frontmatter (biggest impact - unlocks skill routing):
name: valdi-tsxand a richdescriptionfield listing specific capabilities (StatefulComponent lifecycle, setState, viewModel, type-safe styling, provider DI, event handling) and explicit trigger file pathsStructural improvements:
What stayed the same:
quick honest disclosure. I work at https://github.com/tesslio where we build tooling around skills like these. Not a pitch, just saw room for improvement and wanted to contribute.
if you want to self-improve your skills, or define your own scenarios to pressure test, just ask your agent (Claude Code, Codex, etc.) to evaluate and optimize your skill with Tessl. Ping me @yogesh-tessl, if you hit any snags.