Skip to content

fix: harden GitHub OAuth sign-in state/callback handling#1220

Open
alchip wants to merge 1 commit into
SolFoundry:mainfrom
alchip:fix/oauth-signin-821-v2
Open

fix: harden GitHub OAuth sign-in state/callback handling#1220
alchip wants to merge 1 commit into
SolFoundry:mainfrom
alchip:fix/oauth-signin-821-v2

Conversation

@alchip
Copy link
Copy Markdown

@alchip alchip commented May 12, 2026

Summary

  • persist OAuth state from GitHub authorize URL before redirect
  • validate callback state against stored expected value
  • clear stored OAuth state after success/failure paths
  • keep token storage flow consistent in callback login path

Why

Issue #821 requires robust GitHub OAuth sign-in flow. This patch strengthens CSRF/state integrity and callback handling for reliable end-to-end sign-in.

Acceptance mapping

  • Sign-in redirects through GitHub authorize with tracked state
  • Callback validates state and avoids invalid-session continuation
  • Successful callback logs in user and stores tokens/session

Closes #821

Wallet

Wallet: 74jSPYaxEJcGEuW4jr6bqQdg2iuLChyLEuEmC8QhcQVW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🏭 Bounty T1: Fix GitHub OAuth Sign-In Flow

1 participant