-
Notifications
You must be signed in to change notification settings - Fork 8
Update Cypher Function Translations - BED-8261 #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2063eab
fix (pgsql): fix cypher semantic drift for labels function
zinic 096e1b0
feat (pgsql): support relationships, startNode and endNode functions …
zinic 952dff1
fix (pgsql): update type call to return relationship types as a strin…
zinic b07abd7
fix(pgsql): harden Cypher function translation edge cases and regress…
zinic 621a51b
fix(pgsql): materialize path bindings across WITH projections
zinic ae5d313
test (cysql): make labels ordering fixture collation independent
zinic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add language identifiers to the new fenced Cypher examples.
These fenced blocks omit a language tag and trigger MD040 (
fenced-code-language).✏️ Suggested patch
-
+cyphermatch p = (a)-[*1..]->(b)
where none(r in relationships(p) where startNode(r).name = 'blocked')
return p
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
@cypher/CypherSyntax Support.md around lines 248 - 250, The fenced codeblocks containing Cypher examples (e.g., the snippets starting with "match p =
(a)-[*1..]->(b) return relationships(p)", the longer "match p = (a)-[*1..]->(b)
where none(r in relationships(p) where startNode(r).name = 'blocked') return p",
and "match ()-[r]->() return endNode(r)") are missing language identifiers and
trigger MD040; update each triple-backtick fence to include the "cypher"
language tag (```cypher) so the examples are properly tagged for syntax
highlighting and linting.