Tune codespell: move workflow's ignore list into pyproject.toml#270
Open
yarikoptic wants to merge 1 commit into
Open
Tune codespell: move workflow's ignore list into pyproject.toml#270yarikoptic wants to merge 1 commit into
yarikoptic wants to merge 1 commit into
Conversation
The Codespell CI workflow had `ignore_words_list: sortings,trough` baked into the YAML, which is only applied in CI. Running `codespell` locally (or via any other integration) flagged 7 hits for these words that CI silently suppressed — both `sortings` (plural of `Sorting` objects) and `trough` (waveform trough, a real spike-sorting term) are legitimate domain terms, not typos. Move them into `[tool.codespell].ignore-words-list` in pyproject.toml so the config is the single source of truth, and add inline comments explaining each entry. Drop the redundant override and the `codespell-problem-matcher` step from the workflow (problem-matcher annotations are built into `actions-codespell@v2`). Verified: `uvx codespell` exits 0 on the tree. Co-Authored-By: Claude Code 2.1.142 / Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Codespell CI workflow had
ignore_words_list: sortings,troughbaked into the YAML, which is only applied in CI. Runningcodespelllocally (or via any other integration) flagged 7 hits for these words that CI silently suppressed — bothsortings(plural ofSortingobjects) andtrough(waveform trough, a real spike-sorting term) are legitimate domain terms, not typos.Move them into
[tool.codespell].ignore-words-listin pyproject.toml so the config is the single source of truth, and add inline comments explaining each entry. Drop the redundant override and thecodespell-problem-matcherstep from the workflow (problem-matcher annotations are built intoactions-codespell@v2).Verified:
uvx codespellexits 0 on the tree.