Pywake integration#28
Conversation
- Implement PyWakeModel class in wake_model.py with support for multiple deficit models - Update TWFSolver to recognize PyWake wake models - Create example configuration file (run_example_pywake.yaml) - Support for IEA37SimpleBastankhahGaussian, BastankhahGaussian, NOJDeficit, TurboNOJDeficit, and GCLDeficit models - Optional turbulence models: CrespoHernandez and STF2017TurbulenceModel
- Fix conditional FLORIS YAML generation in off_interface.py - Fix conditional FLORIS yaml file handling in off.py - Create working PyWake example configuration (001_two_turbines_yaw_step_pywake.yaml) - Add integration test script (test_pywake_integration.py) - Fix method name (get_current_ct vs get_current_Ct) - Remove invalid ti parameter from PyWake model call - All tests passing successfully
…zation - Implement get_point_vel to return velocity at specific points - Match FLORIS output shape (3, n_points) for u, v, w components - Use simplified implementation returning ambient wind speed - Simulation runs successfully with PyWake backend
Uses momentum theory relationship CT = 4a(1-a) to derive axial induction from PyWake's thrust coefficient output. Includes empirical correction for high thrust conditions (CT > 0.96).
539189f to
afc0bc3
Compare
|
Added pywake class to wake models |
There was a problem hiding this comment.
This file can be removed right? (since it is called 'tmp')
There was a problem hiding this comment.
Should be renamed to either 002_Something or 005_Something
There was a problem hiding this comment.
Ideally, we would include this in the rest of the documentation
There was a problem hiding this comment.
A lot of lines a commented here, should be cleaned up (I don't know what we would want to include though in this one)
| np.savetxt(sim_dir + "/mountain_plot_v_" + str(int(t)).zfill(6) + "s.csv", | ||
| data_v, delimiter=',') | ||
|
|
||
| # # Also create a WS_eff contour map at hub height with OP lines overlay |
There was a problem hiding this comment.
This was previously all uncommented. Should this be uncommented again?
There was a problem hiding this comment.
Can this file be removed? I cannot tell if it is actually used/important
There was a problem hiding this comment.
Probably this change can be undone, since it is specific for the case/run
There was a problem hiding this comment.
This one can either be removed, or alternatively cleaned and put in examples
There was a problem hiding this comment.
Probably can be removed, or potentially upgraded to example
There was a problem hiding this comment.
Can be combined with an example. I would suggest to postpone actual testing until after refactoring (or at least a plan on how/what we refactor)
There was a problem hiding this comment.
Also I tried to run this, but
FileNotFoundError: [Errno 2] No such file or directory: '/home/ivovs/miniconda3/envs/wf/lib/python3.10/site-packages/py_wake/examples/data/iea22mw/IEA-22-280-RWT_tabular.csv'
This .csv is not included by default when installing pywake with
pip install py_wake
or
pip install git+https://gitlab.windenergy.dtu.dk/TOPFARM/PyWake.git
(which is very strange as this means the example in py_wake itself is broken). In order to make it run I needed to manually copy the csv into the py_wake installation folder
No description provided.