docs: fold in Copilot's #115 review nits + restore lost VignetteIndexEntry#116
Merged
Conversation
…Entry #115 was merged from commit 437c48a, before the 2dcdc73 force-push that fixed the vignette index entry, so that fix was lost; this restores it. Plus the three Copilot inline comments on #115: - `vignettes/dockerfiler.Rmd`: section heading "Create a Dockerfile from an renv.lock" -> "... from a renv.lock" (article). - `R/rthis.R` `@examples`, `vignettes/dockerfiler.Rmd` "Basic workflow" chunk, `README.Rmd`: the illustrative `install.packages(..., repos = "http://cran.irsn.fr/")` now uses the canonical HTTPS CRAN mirror `https://cloud.r-project.org` instead of a plaintext-HTTP regional mirror. - restored `%\VignetteIndexEntry{Getting started with dockerfiler}` so it matches the vignette's YAML `title:` (silences the rmarkdown title-mismatch warning). regenerated `man/r.Rd`; re-knit `README.md`. No code-logic change. `devtools::test()` on the touched test file: 0 failures. Vignette renders clean. No en/em-dashes in source.
Member
Author
|
/copilot review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #115. Two things:
Restore the
%\VignetteIndexEntry{Getting started with dockerfiler}fix that was lost: Pre-CRAN polish for 0.3.0 (+ keep Colin as maintainer) #115 was merged from437c48a, before the2dcdc73force-push that aligned the vignette's\VignetteIndexEntry{}to its YAMLtitle:. Without it, rmarkdown emits a title-mismatch warning when rendering the vignette.Fold in Copilot's three inline comments on Pre-CRAN polish for 0.3.0 (+ keep Colin as maintainer) #115:
vignettes/dockerfiler.Rmd: heading "Create a Dockerfile from an renv.lock" → "... from a renv.lock".R/rthis.R@examples,vignettes/dockerfiler.Rmd"Basic workflow" chunk, andREADME.Rmd: the illustrativeinstall.packages(..., repos = "http://cran.irsn.fr/")now uses CRAN's canonical HTTPS mirrorhttps://cloud.r-project.orginstead of a plaintext-HTTP regional mirror.man/r.Rdregenerated;README.mdre-knit. No code-logic change.Verification
devtools::test()ontest-r.R: 0 failures.cran.irsn.frleft anywhere; no en/em-dashes in source.R CMD check --as-crandoesn't check URLs inside\examples{}, but it's a real hygiene improvement; factorized intopr-reviewer.mdcheck Install quarto-cli system dependency when needed #42.)Test plan