Adds a new FieldDescriptor struct#1727
Open
marauder2k7 wants to merge 3 commits into
Open
Conversation
Use the field descriptor struct to add fields instead of the overloads
Adds a visibility function to control whether a field is visible in the inspector
EG:
ADD_FIELD("soundFile", TypeAssetLooseFilePath, Offset(mSoundFile, SoundAsset))
.doc("Path to the sound file.")
.elements(SFXPlayList::SFXPlaylistSettings::NUM_SLOTS)
.onSet(&_setSoundFile);
the grammar can change to make these easier to work with, review changes carefully
Convert sound asset to use the new field constructors Also add a simple example of the visibility control.
If we define an array field have every other field inside that array declared inherit its element count. Can be override with a .elements(N) if N is > 1.
marauder2k7
force-pushed
the
AddField-ControlStruct-AddVisibility-control
branch
from
6829ac2 to
7155801
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the field descriptor struct to add fields instead of the overloads Adds a visibility function to control whether a field is visible in the inspector
EG:
the grammar can change to make these easier to work with, review changes carefully.
This PR is ready and includes a visibility toggle for the inspector, this should make things cleaner for the inspector of certain classes that include arrays of entries, shouldnt allow setting value 22 if value 1 has nothing in it for example.