fix(assert): use distinct error message for assert_not_same and assert_not_equals (#605)

Author: Chemaclass

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+### Fixed
+- Fix misleading error message for `assert_not_same` and `assert_not_equals` on failure #604
+
 ### Added
 - Add `--jobs N` flag to limit parallel test concurrency (e.g., `--jobs 4`)
 - Add `--watch` mode to automatically re-run tests when files change

src/assert.sh

@@ -169,7 +169,7 @@ function assert_not_equals() {
     local label
     label="$(bashunit::helper::normalize_test_function_name "$test_fn")"
     bashunit::assert::mark_failed
-    bashunit::console_results::print_failed_test "${label}" "${expected_cleaned}" "but got " "${actual_cleaned}"
+    bashunit::console_results::print_failed_test "${label}" "${expected_cleaned}" "to not be" "${actual_cleaned}"
     return
   fi
 
@@ -224,7 +224,7 @@ function assert_not_same() {
     local label
     label="$(bashunit::helper::normalize_test_function_name "$test_fn")"
     bashunit::assert::mark_failed
-    bashunit::console_results::print_failed_test "${label}" "${expected}" "but got " "${actual}"
+    bashunit::console_results::print_failed_test "${label}" "${expected}" "to not be" "${actual}"
     return
   fi
 

tests/unit/assert_advanced_test.sh

@@ -18,7 +18,7 @@ function test_successful_assert_not_same() {
 }
 
 function test_unsuccessful_assert_not_same() {
-  assert_same "$(bashunit::console_results::print_failed_test "Unsuccessful assert not same" "1" "but got " "1")" \
+  assert_same "$(bashunit::console_results::print_failed_test "Unsuccessful assert not same" "1" "to not be" "1")" \
     "$(assert_not_same "1" "1")"
 }
 

tests/unit/assert_string_test.sh

@@ -8,7 +8,7 @@ function test_successful_assert_not_equals() {
 }
 
 function test_unsuccessful_assert_not_equals() {
-  assert_same "$(bashunit::console_results::print_failed_test "Unsuccessful assert not equals" "1" "but got " "1")" \
+  assert_same "$(bashunit::console_results::print_failed_test "Unsuccessful assert not equals" "1" "to not be" "1")" \
     "$(assert_not_equals "1" "1")"
 }
 
@@ -18,7 +18,7 @@ function test_unsuccessful_assert_not_equals_with_special_chars() {
 
   assert_equals "$(bashunit::console_results::print_failed_test \
     "Unsuccessful assert not equals with special chars" \
-    "$str1" "but got " "$str2")" \
+    "$str1" "to not be" "$str2")" \
     "$(assert_not_equals "$str1" "$str2")"
 }