enable tests with sanitizers on github actions#297
Closed
malytomas wants to merge 1 commit intoValveSoftware:masterfrom
Closed
enable tests with sanitizers on github actions#297malytomas wants to merge 1 commit intoValveSoftware:masterfrom
malytomas wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
Contributor
|
Thanks for this PR and for highlighting sanitizer findings (especially TSan). Our CI/workflow layout has changed since this was opened (s olong ago, my apologies for being so slow). I now run sanitizer coverage through a different path. I’m going to close this PR as superseded. Thanks for bringing up this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have enabled sanitizers on ubuntu for github actions.
This shows that there are issues detected with thread sanitizer.
(I dont know how to make the triggered linux flavors make working, so I moved it into separate group.)
This PR is relevant to #290