Improve Heisei Dream (partially fixes #4064)#4337
Open
jpenilla wants to merge 2 commits intoVazkiiMods:1.19.xfrom
Open
Improve Heisei Dream (partially fixes #4064)#4337jpenilla wants to merge 2 commits intoVazkiiMods:1.19.xfrom
jpenilla wants to merge 2 commits intoVazkiiMods:1.19.xfrom
Conversation
Does two things: - Set the ATTACK_TARGET memory for mobs using the new Brain system (ie it works on Piglins now) - Override checks in TargetingConditions that prevented Illagers from attacking each other
Doesn't work as is
Collaborator
|
We will likely reimplement this PR after the 1.21 port, using MixinExtras features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overrides checks in TargetingConditions that prevented Illagers from attacking each other
Originally wanted to also fix it for mobs using the new AI system (ie Piglins), but that turned out to be a lot more complicated than I was hoping it would be (so I'm leaving it for a future PR).