Avoid caching the cache (for not explicitly specified thumbnails)#18
Open
eckynde wants to merge 1 commit into
Open
Avoid caching the cache (for not explicitly specified thumbnails)#18eckynde wants to merge 1 commit into
eckynde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an oversight with thumbnail caching I introduced in #17 which caused the thumbnail to appear twice. Under some circumstances (but not in all cases), FreshRSS would feed the already cached url back through the extension before displaying. This caused the cache url to be cachified once more, so the duplicate enclosure detection of FreshRSS did not work, hence appearing twice. Also, yes, we asked our cache endpoint to serve itself, which I find somewhat amusing and which piccache.php will do no questions asked :P but it's probably a good thing that this issue is now fixed.