[NFC] Update ChildTyper callback for unknown constaints#7814
Merged
Conversation
When ChildTyper does not have enough type information to generate type constraints (for example, because a child whose type provides crucial information is unreachable), it previously allowed the user to determine whether to return early or not. But not returning early would then lead to an assertion failure or other bad behavior, so it is never a reasonable choice. The only real choice a user has is to return early and ignore the situation (which is what TypeSSA wants) or to fail loudly because this should never happen (which is what IRBuilder wants). Simplify the callback to allow customizing this behavior but not whether the early return ocurrs.
kripken
approved these changes
Aug 11, 2025
| switch (curr->op) { | ||
| case BrOnNull: | ||
| case BrOnNonNull: | ||
| assert(!target); |
Member
There was a problem hiding this comment.
I'm not sure why this is so. Perhaps add a comment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ChildTyper does not have enough type information to generate type
constraints (for example, because a child whose type provides crucial
information is unreachable), it previously allowed the user to determine
whether to return early or not. But not returning early would then lead
to an assertion failure or other bad behavior, so it is never a
reasonable choice. The only real choice a user has is to return early
and ignore the situation (which is what TypeSSA wants) or to fail loudly
because this should never happen (which is what IRBuilder wants).
Simplify the callback to allow customizing this behavior but not whether
the early return ocurrs.