Fuzzer: Fix branching instructions in non-function scopes#7817
Closed
kripken wants to merge 4 commits intoWebAssembly:mainfrom
Closed
Fuzzer: Fix branching instructions in non-function scopes#7817kripken wants to merge 4 commits intoWebAssembly:mainfrom
kripken wants to merge 4 commits intoWebAssembly:mainfrom
Conversation
tlively
reviewed
Aug 12, 2025
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Should we move these checks up to make and only attempt to make these instructions in a branching context?
Member
Author
|
Root issue should be fixed in #7884 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why this wasn't an issue before, but perhaps we emit more
code in global scopes now?