Fix regression from #7822 about exnrefs with nulls and unknowns#7835
Merged
kripken merged 2 commits intoWebAssembly:mainfrom Aug 15, 2025
Merged
Fix regression from #7822 about exnrefs with nulls and unknowns#7835kripken merged 2 commits intoWebAssembly:mainfrom
kripken merged 2 commits intoWebAssembly:mainfrom
Conversation
tlively
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RootLocation, added in #7822, was overly-ambitious in how much it
simplified. It turns out that there are situations where we need the same
type for both a null and an "unknown" of that type, and a single RootLocation
is therefore not enough (the specific situation the fuzzer found involves
exnref, but perhaps others are possible too).
To fix this, refactor back to two locations, NullLocation and TypeLocation,
where the latter is at least shared by exn and cont as a place with an
unknown value of a type.