-
Notifications
You must be signed in to change notification settings - Fork 124
Add Aliceserver as a debugger target. #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dd86k
wants to merge
12
commits into
WebFreak001:master
Choose a base branch
from
dd86k:dd86k/feature-aliceserver
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bd2a5cc
mi2: Follow tsc type recommendations for some parameters
dd86k 91c2249
Add Aliceserver as a test
dd86k eee2d29
Merge branch 'dd86k/lint-warnings' into dd86k/feature-aliceserver
dd86k bc62abe
Update Initial configuration
dd86k 6fa6420
Add code to support Aliceserver
dd86k 92e983a
package: Add printCalls and showDevDebugOutput for aliceserver
dd86k baa76e8
Misc. progress
dd86k 5e7d193
Merge branch 'master' into dd86k/feature-aliceserver
dd86k f9e183f
package: forgot to set proper descriptions
dd86k e2e2a00
Progress on launching requests
dd86k f79eb59
mi2aliceserver: Redo MI2.stop() with a try-catch when killing debugge…
dd86k 33dd9d9
Merge branch 'WebFreak001:master' into dd86k/feature-aliceserver
dd86k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please send a PR for that one to master?
I haven't checked the current related PR, but maybe there are other pieces outside of alice which you could include in the PR.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can make a PR for these changes. However, if I recall correctly, I did this commit following some tool's recommendation, forgot which, and I haven't checked if these changes cause additional issues. These alone do not depend on anything, thankfully.
Aliceserver & Alicedbg are still (super) WIP, so this PR series will be up as a draft for a while... Sorry.