Skip to content

My first major pull request#3

Open
avholloway wants to merge 1 commit intomainfrom
avh_simple-inbound
Open

My first major pull request#3
avholloway wants to merge 1 commit intomainfrom
avh_simple-inbound

Conversation

@avholloway
Copy link
Copy Markdown
Collaborator

@avholloway avholloway commented Sep 21, 2024

This is mostly a test of the process for me to introduce changes. However, I did take care and consideration for the changes I made, just in case we do end up merging them.

A few things to note:

  1. This is only for the Simple Inbound Template
  2. I built a new flow from scratch, as opposed to modifying the existing one
  3. I re-worded much of the README to both better align with the Flow, and to improve readability

Also, I removed the End Flow activities for a few reasons:

  1. The way they were implemented, did not actually handle the errors. If you test it, it would simply stall the call with silence until the Caller decided to hang up.
  2. I think we should approach Error Handling either in a separate flow template of its own, or introduce it in one of the more complex flow templates.
  3. The Event Flows were not doing anything, so configuring them with End Flows is unnecessary and not required

Similar to item 2 above, I removed the Screen Pop, because not only is it not in the original description, which tells me that maybe it was unintentionally added, either way, I think we should save it for our more complex flow templates.

One final note: I noticed that the flow owner email and version numbers remained on the template. Is this something we can remove before publishing, or should we not concern ourselves with those items? In my opinion, I think it would make for a better template, if there was only one version (no revision history), and if the owner email address was blank. Granted, the flow owner email changes, once a template is published to an Org, but before that, its original value is shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant