My first major pull request#3
Open
avholloway wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly a test of the process for me to introduce changes. However, I did take care and consideration for the changes I made, just in case we do end up merging them.
A few things to note:
Also, I removed the End Flow activities for a few reasons:
Similar to item 2 above, I removed the Screen Pop, because not only is it not in the original description, which tells me that maybe it was unintentionally added, either way, I think we should save it for our more complex flow templates.
One final note: I noticed that the flow owner email and version numbers remained on the template. Is this something we can remove before publishing, or should we not concern ourselves with those items? In my opinion, I think it would make for a better template, if there was only one version (no revision history), and if the owner email address was blank. Granted, the flow owner email changes, once a template is published to an Org, but before that, its original value is shown.