Fix list_direct_messages to skip parentId query param when not provided#5
Open
Ethan-Zhang wants to merge 1 commit intoWebexSamples:mainfrom
Open
Fix list_direct_messages to skip parentId query param when not provided#5Ethan-Zhang wants to merge 1 commit intoWebexSamples:mainfrom
Ethan-Zhang wants to merge 1 commit intoWebexSamples:mainfrom
Conversation
…irect messages function Committer: Ethan-Zhang <unpeeled_onion@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When list_direct_messages is called without the optional parentId argument, the string "undefined" is appended to the request URL as ?parentId=undefined. This causes the Webex API to return an error (e.g., 400 Bad Request) since "undefined" is not a valid parent ID.
Root Cause:
URLSearchParams.append() implicitly calls .toString() on its arguments. When parentId is undefined (not provided by the caller), it gets coerced to the literal string "undefined" rather than being omitted from the query string.
Fix:
Added a guard check (if (parentId)) before appending the parentId query parameter, ensuring it is only included in the request URL when explicitly provided. This is consistent with how personId and personEmail are already handled in the same function.