fix: make JSON Schema to Zod conversion recursive for array/object types#6
Open
etnt wants to merge 1 commit intoWebexSamples:mainfrom
Open
fix: make JSON Schema to Zod conversion recursive for array/object types#6etnt wants to merge 1 commit intoWebexSamples:mainfrom
etnt wants to merge 1 commit intoWebexSamples:mainfrom
Conversation
The VS Code MCP client requires array types to include an `items` schema
in JSON Schema. The previous flat conversion discarded `items` on arrays
and `properties` on objects, producing invalid schemas like `{ type: "array" }`
without items. This caused VS Code to reject all tools with array parameters:
"tool parameters array type must have items"
Extract a recursive `jsonSchemaTypeToZod()` helper that preserves nested
`items` and `properties` when converting to Zod, so the MCP SDK serializes
complete JSON Schema back to the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VS Code MCP client requires array types to include an
itemsschema in JSON Schema. The previous flat conversion discardeditemson arrays andpropertieson objects, producing invalid schemas like{ type: "array" }without items. This caused VS Code to reject all tools with array parameters:"tool parameters array type must have items"
Extract a recursive
jsonSchemaTypeToZod()helper that preserves nesteditemsandpropertieswhen converting to Zod, so the MCP SDK serializes complete JSON Schema back to the client.