fix(gemini): route Vertex token exchange through account proxy#2282
Closed
ZeroDeng01 wants to merge 1 commit intoWei-Shaw:mainfrom
Closed
fix(gemini): route Vertex token exchange through account proxy#2282ZeroDeng01 wants to merge 1 commit intoWei-Shaw:mainfrom
ZeroDeng01 wants to merge 1 commit intoWei-Shaw:mainfrom
Conversation
Contributor
|
All contributors have signed the CLA. ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
修复 Gemini Vertex Service Account 账号测试时,前置 OAuth token 请求没有使用账号代理的问题。
此前账号绑定代理后,后续 Vertex API 请求会走
httpUpstream代理链路,但 Service Account 换取 access token 的请求仍使用裸http.Client直连https://oauth2.googleapis.com/token,在无法直连 Google OAuth 的环境中会超时。Changes
proxyurl与proxyutil代理解析/Transport 配置逻辑。Testing
本地已做:
git diff --checkgofmtgo test ./backend/internal/service -run 'Test(VertexServiceAccountProxyURL|ExchangeVertexServiceAccountTokenUsesProxy)'go test -tags=unit ./...golangci-lint run ./...Notes
这个修复覆盖的是 Vertex Service Account 的 OAuth token 获取阶段,也就是报错中的:
修复后,如果账号绑定了代理,这个 token 请求会和后续 Vertex API 请求一样使用账号代理网络。
close: #2252
I have read the CLA Document and I hereby sign the CLA